linux-kernel - Re: [PATCH v3 4/5] tpm_crb: add support for the Arm FF-A start method

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aba6e089-2b70-465f-a0a0-01274da268f9@arm.com>
Date: Mon, 17 Feb 2025 09:56:20 -0600
From: Stuart Yoder <stuart.yoder@....com>
To: Jarkko Sakkinen <jarkko@...nel.org>
Cc: linux-integrity@...r.kernel.org, peterhuewe@....de, jgg@...pe.ca,
 sudeep.holla@....com, rafael@...nel.org, lenb@...nel.org,
 linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 4/5] tpm_crb: add support for the Arm FF-A start method


>> @@ -119,7 +130,8 @@ static inline bool tpm_crb_has_idle(u32 start_method)
>>   {
>>   	if ((start_method == ACPI_TPM2_START_METHOD) ||
>>   	    (start_method == ACPI_TPM2_COMMAND_BUFFER_WITH_START_METHOD) ||
>> -	    (start_method == ACPI_TPM2_COMMAND_BUFFER_WITH_ARM_SMC))
>> +	    (start_method == ACPI_TPM2_COMMAND_BUFFER_WITH_ARM_SMC) ||
>> +	    (start_method == ACPI_TPM2_CRB_WITH_ARM_FFA))
> 
> Now that we have a chance, let's rip of the parentheses clutter.

Will do that throughout.

>>   		return false;
>>   	else
>>   		return true;
>> @@ -261,6 +273,7 @@ static int crb_cmd_ready(struct tpm_chip *chip)
>>   static int __crb_request_locality(struct device *dev,
>>   				  struct crb_priv *priv, int loc)
>>   {
>> +	int rc;
>>   	u32 value = CRB_LOC_STATE_LOC_ASSIGNED |
>>   		    CRB_LOC_STATE_TPM_REG_VALID_STS;
> 
> Declaration order + put to the same line.

Ack.

Thanks,
Stuart