linux-kernel - Re: [PATCH v1] arm64: dts: ti: k3-am62-verdin-dahlia: add Microphone Jack to sound card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <vax3z776aw6aujpyvwc6zkfqgxn34oawxgc3wn6bjkkj7kjhpz@svmc3nasmjei>
Date: Mon, 17 Feb 2025 21:32:52 +0530
From: Jai Luthra <jai.luthra@...ux.dev>
To: Stefan Eichenberger <eichest@...il.com>
Cc: nm@...com, vigneshr@...com, kristo@...nel.org, robh@...nel.org, 
	krzk+dt@...nel.org, conor+dt@...nel.org, francesco.dolcini@...adex.com, 
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Stefan Eichenberger <stefan.eichenberger@...adex.com>
Subject: Re: [PATCH v1] arm64: dts: ti: k3-am62-verdin-dahlia: add Microphone
 Jack to sound card

Hi Stefan,

Thanks for the patch.

On Mon, Feb 17, 2025 at 03:46:04PM +0100, Stefan Eichenberger wrote:
> From: Stefan Eichenberger <stefan.eichenberger@...adex.com>
> 
> The simple-audio-card's microphone widget currently connects to the
> headphone jack. Routing the microphone input to the microphone jack
> allows for independent operation of the microphone and headphones.
> 
> This resolves the following boot-time kernel log message, which
> indicated a conflict when the microphone and headphone functions were
> not separated:
>   debugfs: File 'Headphone Jack' in directory 'dapm' already present!
> 
> Fixes: f5bf894c865b ("arm64: dts: ti: verdin-am62: dahlia: add sound card")
> Signed-off-by: Stefan Eichenberger <stefan.eichenberger@...adex.com>

Reviewed-by: Jai Luthra <jai.luthra@...ux.dev>

> ---
>  arch/arm64/boot/dts/ti/k3-am62-verdin-dahlia.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-verdin-dahlia.dtsi b/arch/arm64/boot/dts/ti/k3-am62-verdin-dahlia.dtsi
> index 9202181fbd652..fcc4cb2e9389b 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-verdin-dahlia.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-verdin-dahlia.dtsi
> @@ -28,10 +28,10 @@ sound {
>  			"Headphone Jack", "HPOUTR",
>  			"IN2L", "Line In Jack",
>  			"IN2R", "Line In Jack",
> -			"Headphone Jack", "MICBIAS",
> -			"IN1L", "Headphone Jack";
> +			"Microphone Jack", "MICBIAS",
> +			"IN1L", "Microphone Jack";
>  		simple-audio-card,widgets =
> -			"Microphone", "Headphone Jack",
> +			"Microphone", "Microphone Jack",
>  			"Headphone", "Headphone Jack",
>  			"Line", "Line In Jack";
>  
> -- 
> 2.45.2
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)