linux-kernel - Re: [PATCH v2 03/11] sched: Add sched tracepoints for RV task model

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250217164917.GB40464@noisy.programming.kicks-ass.net>
Date: Mon, 17 Feb 2025 17:49:17 +0100
From: Peter Zijlstra <peterz@...radead.org>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Gabriele Monaco <gmonaco@...hat.com>, linux-kernel@...r.kernel.org,
	Ingo Molnar <mingo@...hat.com>,
	Masami Hiramatsu <mhiramat@...nel.org>,
	linux-trace-kernel@...r.kernel.org,
	Juri Lelli <juri.lelli@...hat.com>
Subject: Re: [PATCH v2 03/11] sched: Add sched tracepoints for RV task model

On Mon, Feb 17, 2025 at 11:38:44AM -0500, Steven Rostedt wrote:

> > +void __do_trace_set_current_state(int state_value)
> > +{
> > +	__do_trace_sched_set_state_tp(current, current->__state, state_value);
> 
> And this should not be using the internal macros of a trace point. It should be:
> 
> 	trace_sched_set_state_tp(current, state_value);
> 
> (I removed the current->__state as mentioned above).

But the static branch is already in the caller, no point duplicating
that.