linux-kernel - Re: [PATCH v6 0/6] Add Synopsys DesignWare HDMI RX Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6638b286-2e5e-4861-bb85-2e29556b0b02@collabora.com>
Date: Mon, 17 Feb 2025 21:16:06 +0300
From: Dmitry Osipenko <dmitry.osipenko@...labora.com>
To: Hans Verkuil <hverkuil@...all.nl>,
 Shreeya Patel <shreeya.patel@...labora.com>, Heiko Stuebner
 <heiko@...ech.de>, Mauro Carvalho Chehab <mchehab@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, jose.abreu@...opsys.com,
 nelson.costa@...opsys.com, shawn.wen@...k-chips.com,
 nicolas.dufresne@...labora.com,
 Sebastian Reichel <sebastian.reichel@...labora.com>
Cc: kernel@...labora.com, linux-media@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-rockchip@...ts.infradead.org, Tim Surber <me@...surber.de>
Subject: Re: [PATCH v6 0/6] Add Synopsys DesignWare HDMI RX Controller

On 2/17/25 11:34, Hans Verkuil wrote:
> Hi Dmitry,
> 
> On 15/02/2025 22:04, Dmitry Osipenko wrote:
>> This series implements support for the Synopsys DesignWare
>> HDMI RX Controller, being compliant with standard HDMI 1.4b
>> and HDMI 2.0.
>>
>> Features that are currently supported by the HDMI RX driver
>> have been tested on rock5b board using a HDMI to micro-HDMI cable.
>> It is recommended to use a good quality cable as there were
>> multiple issues seen during testing the driver.
>>
>> Please note the below information :-
>> * HDMIRX driver now only works with the opensource TF-A.
>> * We have tested the working of OBS studio with HDMIRX driver and
>> there were no issues seen.
>> * We tested and verified the support for interlaced video.
>> * We tested capturing of YUV formats.
>>
>> To test the HDMI RX Controller driver, following example commands can be used :-
>>
>> root@...ian-rockchip-rock5b-rk3588:~# v4l2-ctl --verbose -d /dev/video0 \
>> --set-fmt-video=width=1920,height=1080,pixelformat='BGR3' --stream-mmap=4 \
>> --stream-skip=3 --stream-count=100 --stream-to=/home/hdmiin4k.raw --stream-poll
> 
> This looks a bit odd. This commandline should work just as well:
> 
> v4l2-ctl --stream-mmap --stream-count=100 --stream-to=/home/hdmiin4k.raw
> 
> v4l2-ctl will call QUERY_DV_TIMINGS, then (if a valid signal is found) S_DV_TIMINGS.
> That in turn updates the v4l2_format. So there is no need to set the video format,
> it should happen automatically.

Your cmdline works fine, setting format isn't necessary.

> Also, why skip the first three frames? And why select --stream-poll?
> 
> It could be that these are just left-overs from previous attempts, but it's
> weird.

It's indeed the left-overs, will edit the cover letter in v7.

> I also commented on the debugfs InfoFrame code in patch 4/6, that's not
> correct.

Thanks for the thorough review! :)

Additional note: I'm going to finish upstreaming of the driver because
Shreeya is currently busy. She will be maintaining driver afterwards.

-- 
Best regards,
Dmitry