[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAA1CXcAK8tMVhWJLO9OrkyBpA6ZdPv7f99igBphLhLxVM5zJxA@mail.gmail.com>
Date: Mon, 17 Feb 2025 12:23:45 -0700
From: Nico Pache <npache@...hat.com>
To: Usama Arif <usamaarif642@...il.com>
Cc: linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
linux-kselftest@...r.kernel.org, linux-mm@...ck.org, ryan.roberts@....com,
anshuman.khandual@....com, catalin.marinas@....com, cl@...two.org,
vbabka@...e.cz, mhocko@...e.com, apopple@...dia.com,
dave.hansen@...ux.intel.com, will@...nel.org, baohua@...nel.org, jack@...e.cz,
srivatsa@...il.mit.edu, haowenchao22@...il.com, hughd@...gle.com,
aneesh.kumar@...nel.org, yang@...amperecomputing.com, peterx@...hat.com,
ioworker0@...il.com, wangkefeng.wang@...wei.com, ziy@...dia.com,
jglisse@...gle.com, surenb@...gle.com, vishal.moola@...il.com,
zokeefe@...gle.com, zhengqi.arch@...edance.com, jhubbard@...dia.com,
21cnbao@...il.com, willy@...radead.org, kirill.shutemov@...ux.intel.com,
david@...hat.com, aarcange@...hat.com, raquini@...hat.com, dev.jain@....com,
sunnanyong@...wei.com, audra@...hat.com, akpm@...ux-foundation.org,
rostedt@...dmis.org, mathieu.desnoyers@...icios.com, tiwai@...e.de,
baolin.wang@...ux.alibaba.com, corbet@....net, shuah@...nel.org
Subject: Re: [RFC v2 0/5] mm: introduce THP deferred setting
On Mon, Feb 17, 2025 at 7:54 AM Usama Arif <usamaarif642@...il.com> wrote:
>
>
>
> On 11/02/2025 00:40, Nico Pache wrote:
> > This series is a follow-up to [1], which adds mTHP support to khugepaged.
> > mTHP khugepaged support was necessary for the global="defer" and
> > mTHP="inherit" case (and others) to make sense.
> >
>
> Hi Nico,
>
> Thanks for the patches!
Hi Usama,
Thank you for the review!
>
> Why is mTHP khugepaged a prerequisite for THP=defer?
> THP=defer applies to PMD hugepages as well, so they should be independent.
Its not a hard prerequisite, but I explained it a little here:
https://lore.kernel.org/lkml/CAA1CXcBPt4jHfH0Ggio5ghSYAQAXf08rO8R6b1faHzdjFf_Ajw@mail.gmail.com/
In general, the sysfs didnt really make sense without it, and given
mTHPs came along right when i was working on defer, I decided to add
it to mTHP too.
I worked on and tested these together so it felt right to sync up the
V2s for both of them.
Cheers,
-- Nico
>
>
>
Powered by blists - more mailing lists