linux-kernel - Re: [PATCH v1 3/5] gpio: regmap: Group optional assignments together for better understanding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D7UJUHPZNH5I.2YIX1Q3AFB7ED@kernel.org>
Date: Mon, 17 Feb 2025 08:40:48 +0100
From: "Michael Walle" <mwalle@...nel.org>
To: "Andy Shevchenko" <andriy.shevchenko@...ux.intel.com>, "Bartosz
 Golaszewski" <bartosz.golaszewski@...aro.org>,
 <linux-gpio@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Cc: "Linus Walleij" <linus.walleij@...aro.org>, "Bartosz Golaszewski"
 <brgl@...ev.pl>, "athieu Dubois-Briand" <mathieu.dubois-briand@...tlin.com>
Subject: Re: [PATCH v1 3/5] gpio: regmap: Group optional assignments
 together for better understanding

On Thu Feb 13, 2025 at 8:48 PM CET, Andy Shevchenko wrote:
> Group ngpio_per_reg, reg_stride, and reg_mask_xlate assignments together
> with the respective conditional for better understanding what's going on
> in the code.
>
> While at it, mark ngpio_per_reg as (Optional) in the kernel-doc
> in accordance with what code actually does.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Reviewed-by: Michael Walle <mwalle@...nel.org>

Download attachment "signature.asc" of type "application/pgp-signature" (298 bytes)