linux-kernel - Re: [PATCH next] media: iris: fix error code in iris_load_fw_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4206de50-2970-a93b-867a-03ae6cdcedd3@quicinc.com>
Date: Mon, 17 Feb 2025 13:42:42 +0530
From: Dikshita Agarwal <quic_dikshita@...cinc.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
CC: Vikash Garodia <quic_vgarodia@...cinc.com>,
        Abhinav Kumar
	<quic_abhinavk@...cinc.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Stefan Schmidt <stefan.schmidt@...aro.org>,
        Hans Verkuil
	<hverkuil@...all.nl>, <linux-media@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH next] media: iris: fix error code in
 iris_load_fw_to_memory()



On 2/17/2025 1:38 PM, Dan Carpenter wrote:
> Return -ENOMEM if memremap() fails.  Don't return success.
> 
> Fixes: d19b163356b8 ("media: iris: implement video firmware load/unload")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  drivers/media/platform/qcom/iris/iris_firmware.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/qcom/iris/iris_firmware.c b/drivers/media/platform/qcom/iris/iris_firmware.c
> index 7c493b4a75db..f1b5cd56db32 100644
> --- a/drivers/media/platform/qcom/iris/iris_firmware.c
> +++ b/drivers/media/platform/qcom/iris/iris_firmware.c
> @@ -53,8 +53,10 @@ static int iris_load_fw_to_memory(struct iris_core *core, const char *fw_name)
>  	}
>  
>  	mem_virt = memremap(mem_phys, res_size, MEMREMAP_WC);
> -	if (!mem_virt)
> +	if (!mem_virt) {
> +		ret = -ENOMEM;
>  		goto err_release_fw;
> +	}>
>  	ret = qcom_mdt_load(dev, firmware, fw_name,
>  			    pas_id, mem_virt, mem_phys, res_size, NULL);

Thanks for the fix.
Reviewed-by: Dikshita Agarwal <quic_dikshita@...cinc.com>

Thanks,
Dikshita