linux-kernel - Re: [PATCH] arm64: dts: socfpga: agilex5: add gpio led and memory node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8e5bbd2b-a4e1-417b-88d0-267450c7cf86@kernel.org>
Date: Mon, 17 Feb 2025 10:08:40 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: niravkumar.l.rabara@...el.com, Dinh Nguyen <dinguyen@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, nirav.rabara@...era.com,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: socfpga: agilex5: add gpio led and memory
 node

On 17/02/2025 06:27, niravkumar.l.rabara@...el.com wrote:
> From: Niravkumar L Rabara <niravkumar.l.rabara@...el.com>
> 
> Add GPIO led and memory node for Agilex5 devkit.
> 
> Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@...el.com>
> ---
>  .../boot/dts/intel/socfpga_agilex5_socdk.dts  | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts
> index c533e5a3a610..59530eada2ea 100644
> --- a/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts
> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts
> @@ -15,6 +15,25 @@ aliases {
>  	chosen {
>  		stdout-path = "serial0:115200n8";
>  	};

Missing blank line

> +	leds {
> +		compatible = "gpio-leds";
> +
> +		led1 {

led-0

> +			label = "hps_led1";
> +			gpios = <&porta 11 GPIO_ACTIVE_HIGH>;
> +		};
> +

And that's not necessary

> +	};
> +


Best regards,
Krzysztof