linux-kernel - Re: [PATCH] ARM: dts: microchip: Move address/size-cells properties to SoC dtsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20250217-jogging-retention-c1947d68bac8@thorsis.com>
Date: Mon, 17 Feb 2025 10:15:42 +0100
From: Alexander Dahl <ada@...rsis.com>
To: Claudiu Beznea <claudiu.beznea@...on.dev>
Cc: Alexander Dahl <ada@...rsis.com>, devicetree@...r.kernel.org,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Nicolas Ferre <nicolas.ferre@...rochip.com>,
	Alexandre Belloni <alexandre.belloni@...tlin.com>,
	Peter Rosin <peda@...ntia.se>,
	"moderated list:ARM/Microchip (AT91) SoC support" <linux-arm-kernel@...ts.infradead.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: dts: microchip: Move address/size-cells properties
 to SoC dtsi

Hello Claudiu,

Am Mon, Feb 17, 2025 at 09:05:47AM +0200 schrieb Claudiu Beznea:
> Hi, Alexander,
> 
> 
> On 04.02.2025 18:52, Alexander Dahl wrote:
> > Avoids warnings with board dts files enabling ethernet-controller node
> > together with phy child node(s).
> > 
> > Signed-off-by: Alexander Dahl <ada@...rsis.com>
> > ---
> >  arch/arm/boot/dts/microchip/at91-dvk_su60_somc.dtsi    | 4 ----
> >  arch/arm/boot/dts/microchip/at91-sam9_l9260.dts        | 2 --
> >  arch/arm/boot/dts/microchip/at91-sam9x60_curiosity.dts | 2 --
> >  arch/arm/boot/dts/microchip/at91-sam9x60ek.dts         | 2 --
> >  arch/arm/boot/dts/microchip/at91-sama5d27_som1.dtsi    | 2 --
> >  arch/arm/boot/dts/microchip/at91-sama5d27_wlsom1.dtsi  | 2 --
> >  arch/arm/boot/dts/microchip/at91-sama5d2_ptc_ek.dts    | 2 --
> >  arch/arm/boot/dts/microchip/at91-sama5d2_xplained.dts  | 2 --
> >  arch/arm/boot/dts/microchip/at91-sama5d3_xplained.dts  | 4 ----
> >  arch/arm/boot/dts/microchip/at91-sama7g5ek.dts         | 4 ----
> >  arch/arm/boot/dts/microchip/at91-tse850-3.dts          | 3 ---
> >  arch/arm/boot/dts/microchip/at91-vinco.dts             | 3 ---
> >  arch/arm/boot/dts/microchip/at91rm9200.dtsi            | 2 ++
> >  arch/arm/boot/dts/microchip/at91sam9260.dtsi           | 2 ++
> >  arch/arm/boot/dts/microchip/at91sam9263.dtsi           | 2 ++
> >  arch/arm/boot/dts/microchip/at91sam9g45.dtsi           | 2 ++
> >  arch/arm/boot/dts/microchip/at91sam9x5_macb0.dtsi      | 2 ++
> >  arch/arm/boot/dts/microchip/at91sam9x5_macb1.dtsi      | 2 ++
> >  arch/arm/boot/dts/microchip/sam9x60.dtsi               | 4 ++++
> >  arch/arm/boot/dts/microchip/sam9x7.dtsi                | 2 ++
> >  arch/arm/boot/dts/microchip/sama5d2.dtsi               | 2 ++
> >  arch/arm/boot/dts/microchip/sama5d3_emac.dtsi          | 2 ++
> >  arch/arm/boot/dts/microchip/sama5d3_gmac.dtsi          | 2 ++
> >  arch/arm/boot/dts/microchip/sama5d3xcm_cmp.dtsi        | 2 --
> >  arch/arm/boot/dts/microchip/sama5d3xmb_cmp.dtsi        | 2 --
> >  arch/arm/boot/dts/microchip/sama5d3xmb_emac.dtsi       | 2 --
> >  arch/arm/boot/dts/microchip/sama5d3xmb_gmac.dtsi       | 2 --
> >  arch/arm/boot/dts/microchip/sama7g5.dtsi               | 4 ++++
> >  28 files changed, 28 insertions(+), 40 deletions(-)
> > 
> 
> There are some other warnings triggered by these changes:

Are these somehow mixed due to parallel building?  Some lines don't
make sense to me.  I tried reproducing with `make dtbs W=1` now, and I
think I identified three warnings which match your output.

> 
>   DTC [C] arch/arm/boot/dts/microchip/at91sam9m10g45ek.dtb
> ../arch/arm/boot/dts/microchip/at91rm9200.dtsi:213.29-225.6: Warning
> (avoid_unnecessary_addr_size): /ahb/apb/ethernet@...bc000: unnecessary
> #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg"
> property
> /home/claudiu/repos/linux-microchip/build-arm32/arch/arm/boot/dts/microchip/at91rm9200ek.dtb:
> ethernet-phy: 'reg' is a required property

Not sure how at91sam9m10g45ek comes in here, but for at91rm9200ek this
warning is due to eth having a phy subnode without explicit <reg>
address.  I could not determine the address from looking at RM9200-EK
schematics, which states the board would have a DM9161E PHY, and the
datasheet of that PHY.

The at91rm9200.dtsi is just used by two other dts/dtsi files, which do
not have a phy sub node.

We could _not_ add the address/size properties to the eth node in
at91rm9200.dtsi, which would probably make this dts warning go away.
This would violate dt bindings however, namely net/cdns,macb.yaml and
net/ethernet-phy.yaml … so I'm not sure how to proceed here?

> ../arch/arm/boot/dts/microchip/sama5d3_gmac.dtsi:66.29-77.6: Warning
> (avoid_unnecessary_addr_size): /ahb/apb/ethernet@...28000: unnecessary
> #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg"
> property
>   also defined at
> ../arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts:50.8-58.3
> ../arch/arm/boot/dts/microchip/sama5d2.dtsi:382.29-393.6: Warning
> (avoid_unnecessary_addr_size): /ahb/apb/ethernet@...08000: unnecessary
> #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg"
> property

Contrary to other boards using the sama5d2.dtsi the
at91-sama5d2_icp.dts uses a "fixed-link" subnode instead of
"ethernet-phy@?" subnode.  According to
Documentation/devicetree/bindings/net/cdns,macb.yaml this looks okay
to me.  Not sure why dtc throws a warning here.

Same for at91-sama5d3_ksz9477_evb.dts using sama5d3_gmac.dtsi

So in my opinion all three are problems with .dtb where I have no idea
how to solve that:

- microchip/at91rm9200ek.dtb
- microchip/at91-sama5d2_icp.dtb
- microchip/at91-sama5d3_ksz9477_evb.dtb

Suggestions?

Greets
Alex