linux-kernel - Re: [PATCH v2 12/12] dt-bindings: mtd: raw-nand-chip: Relax node name pattern

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87tt8svrxf.fsf@bootlin.com>
Date: Mon, 17 Feb 2025 10:31:08 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: J. Neuschäfer <j.ne@...teo.net>
Cc: J. Neuschäfer via B4 Relay
 <devnull+j.ne.posteo.net@...nel.org>,
  devicetree@...r.kernel.org,  linuxppc-dev@...ts.ozlabs.org,  Krzysztof
 Kozlowski <krzk@...nel.org>,  imx@...ts.linux.dev,  Scott Wood
 <oss@...error.net>,  Madhavan Srinivasan <maddy@...ux.ibm.com>,  Michael
 Ellerman <mpe@...erman.id.au>,  Nicholas Piggin <npiggin@...il.com>,
  Christophe Leroy <christophe.leroy@...roup.eu>,  Naveen N Rao
 <naveen@...nel.org>,  Rob Herring <robh@...nel.org>,  Krzysztof Kozlowski
 <krzk+dt@...nel.org>,  Conor Dooley <conor+dt@...nel.org>,  Damien Le Moal
 <dlemoal@...nel.org>,  Niklas Cassel <cassel@...nel.org>,  Herbert Xu
 <herbert@...dor.apana.org.au>,  "David S. Miller" <davem@...emloft.net>,
  Lee Jones <lee@...nel.org>,  Vinod Koul <vkoul@...nel.org>,  Lorenzo
 Pieralisi <lpieralisi@...nel.org>,  Krzysztof Wilczyński
 <kw@...ux.com>,
  Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,  Bjorn Helgaas
 <bhelgaas@...gle.com>,  J. Neuschäfer
 <j.neuschaefer@....net>,  Wim Van
 Sebroeck <wim@...ux-watchdog.org>,  Guenter Roeck <linux@...ck-us.net>,
  Mark Brown <broonie@...nel.org>,  Richard Weinberger <richard@....at>,
  Vignesh Raghavendra <vigneshr@...com>,  linux-kernel@...r.kernel.org,
  linux-ide@...r.kernel.org,  linux-crypto@...r.kernel.org,
  dmaengine@...r.kernel.org,  linux-pci@...r.kernel.org,
  linux-watchdog@...r.kernel.org,  linux-spi@...r.kernel.org,
  linux-mtd@...ts.infradead.org
Subject: Re: [PATCH v2 12/12] dt-bindings: mtd: raw-nand-chip: Relax node
 name pattern

Hello,

>> > In some scenarios, such as under the Freescale eLBC bus, there are raw
>> > NAND chips with a unit address that has a comma in it (cs,offset).
>> > Relax the $nodename pattern in raw-nand-chip.yaml to allow such unit
>> > addresses.
>> 
>> This is super specific to this controller, I'd rather avoid that in the
>> main (shared) files. I believe you can force another node name in the
>> controller's binding instead?
>
> It's a bit tricky. AFAICS, when I declare a node name pattern in my
> specific binding in addition to the generic binding, the result is that
> both of them apply, so I can't relax stricter requirements:
>
> # raw-nand-chip.yaml
> properties:
>   $nodename:
>     pattern: "^nand@[a-f0-9]$"
>
> # fsl,elbc-fcm-nand.yaml
> properties:
>   $nodename:
>     pattern: "^nand@[a-f0-9](,[0-9a-f]*)?$"

Well, I guess this is creating a second possible node name.

> # dtc
> /.../fsl,elbc-fcm-nand.example.dtb:
> nand@1,0: $nodename:0: 'nand@1,0' does not match '^nand@[a-f0-9]$'
>         from schema $id:
> 	http://devicetree.org/schemas/mtd/fsl,elbc-fcm-nand.yaml#

What about fixing the DT instead?

> (I changed the second pattern to nand-fail@... and dtc warned about it
>  mismatching too.)
>
> Perhaps I'm missing a DT-schema trick to override a value/pattern.
>
> Alternatively (pending discussion on patch 11/12), I might end up not
> referencing raw-nand-chip.yaml.

Ok.

Thanks,
Miquèl