linux-kernel - Re: [PATCH v1 2/5] ASoC: wm8904: Don't touch GPIO configs set to 0xFFFF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z7MH7nZHq7GXRoQP@opensource.cirrus.com>
Date: Mon, 17 Feb 2025 09:57:02 +0000
From: Charles Keepax <ckeepax@...nsource.cirrus.com>
To: Francesco Dolcini <francesco@...cini.it>
CC: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
        "Rob
 Herring" <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        "Conor
 Dooley" <conor+dt@...nel.org>,
        Saravana Kannan <saravanak@...gle.com>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        <patches@...nsource.cirrus.com>,
        Ernest Van Hoecke
	<ernest.vanhoecke@...adex.com>,
        <linux-sound@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        "Francesco
 Dolcini" <francesco.dolcini@...adex.com>
Subject: Re: [PATCH v1 2/5] ASoC: wm8904: Don't touch GPIO configs set to
 0xFFFF

On Thu, Feb 06, 2025 at 05:31:49PM +0100, Francesco Dolcini wrote:
> From: Ernest Van Hoecke <ernest.vanhoecke@...adex.com>
> 
> When updating the GPIO registers, do nothing for all fields of gpio_cfg
> that are "0xFFFF".
> 
> This "do nothing" flag used to be 0 to easily check whether the gpio_cfg
> field was actually set inside pdata or left empty (default).
> 
> However, 0 is a valid configuration for these registers, while 0xFFFF is
> not.
> 
> With this change, users can explicitly set them to 0. Not setting
> gpio_cfg in the platform data will now lead to setting all GPIO
> registers to 0 instead of leaving them unset.
> 
> No one is using this platform data with this codec.
> 
> The change gets the driver ready to properly set gpio_cfg from the DT.
> 
> Datasheet: https://statics.cirrus.com/pubs/proDatasheet/WM8904_Rev4.1.pdf
> Signed-off-by: Ernest Van Hoecke <ernest.vanhoecke@...adex.com>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@...adex.com>
> ---

Reviewed-by: Charles Keepax <ckeepax@...nsource.cirrus.com>

Thanks,
Charles