linux-kernel - Re: [PATCH 1/2] dt-bindings: trivial-devices: add lt3074

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bcadb20f-4867-4b77-ac53-f855b14cd746@kernel.org>
Date: Mon, 17 Feb 2025 11:52:09 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Encarnacion, Cedric justine" <Cedricjustine.Encarnacion@...log.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Jean Delvare <jdelvare@...e.com>,
 Guenter Roeck <linux@...ck-us.net>, Jonathan Corbet <corbet@....net>,
 Delphine CC Chiu <Delphine_CC_Chiu@...ynn.com>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
 "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
 "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: trivial-devices: add lt3074

On 17/02/2025 10:30, Encarnacion, Cedric justine wrote:
>>
>>> LT7182S. Like other PMBus drivers, its GPIOs are not exposed.
>>>
>>> Here are other PMBus regulators/power modules found in trivial-devices
>>> I also used as reference:
>>>
>>> - infineon,irps5401
>>> - delta,q54sj108a2
>>
>>
>> I don't know these devices so still no clue. Please rather explain in
>> the terms of the hardware, e.g. what this device has or has not. See
>> also regulator bindings.
> 
> The device has enable-gpio and status-gpio. It also has registers of
> similar functionality which the core driver accesses instead for
> toggling enable and monitoring status of the device.
> 
> Upon checking regulator bindings and other related bindings for
> PMBus devices with regulator support, this indeed should be a
> separate binding outside of trivial devices. Please let me know
> what do you suggest.

Even the GPIOs are outside of trivial devices, so for that sole reason
this should not be here but in its own binding.

Best regards,
Krzysztof