linux-kernel - [PATCH 1/5] ring-buffer: Update pages_touched to reflect persistent buffer content

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250217024639.1980139-1-zengheng4@huawei.com>
Date: Mon, 17 Feb 2025 10:46:35 +0800
From: Zeng Heng <zengheng4@...wei.com>
To: <peterz@...radead.org>, <masahiroy@...nel.org>, <mgorman@...e.de>,
	<guoweikang.kernel@...il.com>, <mingo@...hat.com>,
	<vincent.guittot@...aro.org>, <hpa@...or.com>, <agordeev@...ux.ibm.com>,
	<vschneid@...hat.com>, <tzimmermann@...e.de>, <dave.hansen@...ux.intel.com>,
	<ardb@...nel.org>, <mhiramat@...nel.org>, <juri.lelli@...hat.com>,
	<geert@...ux-m68k.org>, <bp@...en8.de>, <pavel@....cz>,
	<simona.vetter@...ll.ch>, <bp@...e.de>, <rostedt@...dmis.org>,
	<bsegall@...gle.com>, <nicolas@...sle.eu>, <sebastian.reichel@...labora.com>,
	<tglx@...utronix.de>, <akpm@...ux-foundation.org>,
	<mathieu.desnoyers@...icios.com>, <dietmar.eggemann@....com>,
	<lkundrak@...sk>, <changhuaixin@...ux.alibaba.com>, <nathan@...nel.org>,
	<javierm@...hat.com>
CC: <linux-trace-kernel@...r.kernel.org>, <linux-efi@...r.kernel.org>,
	<bobo.shaobowang@...wei.com>, <linux-kbuild@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <x86@...nel.org>
Subject: [PATCH 1/5] ring-buffer: Update pages_touched to reflect persistent buffer content

From: Steven Rostedt <rostedt@...dmis.org>

The pages_touched field represents the number of subbuffers in the ring
buffer that have content that can be read. This is used in accounting of
"dirty_pages" and "buffer_percent" to allow the user to wait for the
buffer to be filled to a certain amount before it reads the buffer in
blocking mode.

The persistent buffer never updated this value so it was set to zero, and
this accounting would take it as it had no content. This would cause user
space to wait for content even though there's enough content in the ring
buffer that satisfies the buffer_percent.

Cc: stable@...r.kernel.org
Cc: Masami Hiramatsu <mhiramat@...nel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Cc: Vincent Donnefort <vdonnefort@...gle.com>
Link: https://lore.kernel.org/20250214123512.0631436e@gandalf.local.home
Fixes: 5f3b6e839f3ce ("ring-buffer: Validate boot range memory events")
Signed-off-by: Steven Rostedt (Google) <rostedt@...dmis.org>
---
 kernel/trace/ring_buffer.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
index 0419d41a2060..bb6089c2951e 100644
--- a/kernel/trace/ring_buffer.c
+++ b/kernel/trace/ring_buffer.c
@@ -1850,6 +1850,11 @@ static void rb_meta_validate_events(struct ring_buffer_per_cpu *cpu_buffer)
 				cpu_buffer->cpu);
 			goto invalid;
 		}
+
+		/* If the buffer has content, update pages_touched */
+		if (ret)
+			local_inc(&cpu_buffer->pages_touched);
+
 		entries += ret;
 		entry_bytes += local_read(&head_page->page->commit);
 		local_set(&cpu_buffer->head_page->entries, ret);
-- 
2.25.1