linux-kernel - Re: [PATCH] PCI: endpoint: Remove API devm_pci_epc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a99e4576-ca9a-4b28-9a5b-242184de852c@icloud.com>
Date: Mon, 17 Feb 2025 20:06:42 +0800
From: Zijun Hu <zijun_hu@...oud.com>
To: Manivannan Sadhasivam <mani@...nel.org>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 Krzysztof Wilczyński <kw@...ux.com>,
 Kishon Vijay Abraham I <kishon@...nel.org>,
 Bjorn Helgaas <bhelgaas@...gle.com>, Jonathan Corbet <corbet@....net>,
 linux-pci@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, Zijun Hu <quic_zijuhu@...cinc.com>
Subject: Re: [PATCH] PCI: endpoint: Remove API devm_pci_epc_destroy()

On 2025/2/14 23:40, Manivannan Sadhasivam wrote:
> On Mon, Feb 10, 2025 at 08:39:53PM +0800, Zijun Hu wrote:
>> From: Zijun Hu <quic_zijuhu@...cinc.com>
>>
>> Static devm_pci_epc_match() is only invoked by API devm_usb_put_phy(), and
> devm_usb_put_phy()? Did you mean to say 'devm_pci_epc_destroy()'?
> 

yes. it is devm_pci_epc_destroy().
my mistake, thank you for pointing out this.
will correct in v2. (^^)

>> the API has not had callers since 2017-04-10 when it was introduced.
>>
>> Remove both the API and the static function.
>>
>> Signed-off-by: Zijun Hu <quic_zijuhu@...cinc.com>
> With above fixup,
> 
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> 
> - Mani