linux-kernel - Re: [PATCH v5 RESEND] cpuidle: psci: Add trace for PSCI domain idle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z7MsM5Va5xi-Nuis@bogus>
Date: Mon, 17 Feb 2025 12:31:47 +0000
From: Sudeep Holla <sudeep.holla@....com>
To: "Rafael J. Wysocki" <rafael@...nel.org>
Cc: Keita Morisaki <keyz@...gle.com>, Ulf Hansson <ulf.hansson@...aro.org>,
	lpieralisi@...nel.org, linux-kernel@...r.kernel.org,
	daniel.lezcano@...aro.org, linux-pm@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, rostedt@...dmis.org,
	mhiramat@...nel.org, mathieu.desnoyers@...icios.com,
	linux-trace-kernel@...r.kernel.org, aarontian@...gle.com,
	Sudeep Holla <sudeep.holla@....com>, yimingtseng@...gle.com,
	Dhruva Gole <d-gole@...com>, Kevin Hilman <khilman@...libre.com>
Subject: Re: [PATCH v5 RESEND] cpuidle: psci: Add trace for PSCI domain idle

On Mon, Feb 17, 2025 at 12:57:07PM +0100, Rafael J. Wysocki wrote:
> +Ulf
> 
> On Mon, Feb 10, 2025 at 6:58 AM Keita Morisaki <keyz@...gle.com> wrote:
> >
> > The trace event cpu_idle provides insufficient information for debugging
> > PSCI requests due to lacking access to determined PSCI domain idle
> > states. The cpu_idle usually only shows -1, 0, or 1 regardless how many
> > idle states the power domain has.
> >
> > Add new trace events namely psci_domain_idle_enter and
> > psci_domain_idle_exit to trace enter and exit events with a determined
> > idle state.
> >
> > These new trace events will help developers debug CPUidle issues on ARM
> > systems using PSCI by providing more detailed information about the
> > requested idle states.
> >
> > Signed-off-by: Keita Morisaki <keyz@...gle.com>
> > Reviewed-by: Steven Rostedt (Google) <rostedt@...dmis.org>
> > Reviewed-by: Dhruva Gole <d-gole@...com>
> > Tested-by: Kevin Hilman <khilman@...libre.com>
> > ---
> > v1->v2: Split the ftrace event into two (psci_domain_idle_(enter|exit))
> >         and rephrase the commit message accordingly. Rebased onto the latest.
> > v2->v3: Add "Reviewed-by: Steven Rostedt"
> > v3->v4: Add the Tested-by label
> > v4->v5: Add "Reviewed-by: Dhruva Gole"
> >
> > Hopefully this patch gets attention from maintainers of
> > drivers/cpuidle/cpuidle-psci.c too.
>
> Lorenzo, Sudeep, Ulf, any comments?
>

Looks good to me. I left it to Ulf, FWIW:

Acked-by: Sudeep Holla <sudeep.holla@....com>

-- 
Regards,
Sudeep