linux-kernel - Re: [PATCH] m68k: mm: Replace deprecated strncpy() with strscpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b5ed8cc5-ae78-42f7-bbb8-8f9d286ed7b6@yoseli.org>
Date: Mon, 17 Feb 2025 14:01:29 +0100
From: Jean-Michel Hautbois <jeanmichel.hautbois@...eli.org>
To: Thorsten Blum <thorsten.blum@...ux.dev>,
 Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: linux-hardening@...r.kernel.org, linux-m68k@...ts.linux-m68k.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] m68k: mm: Replace deprecated strncpy() with strscpy()

Hi Thorsten,

On 2/13/25 3:10 PM, Thorsten Blum wrote:
> strncpy() is deprecated for NUL-terminated destination buffers. Use
> strscpy() instead and remove the manual NUL-termination.
> 
> Compile-tested only.
> 
> Link: https://github.com/KSPP/linux/issues/90
> Cc: linux-hardening@...r.kernel.org
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>

Thanks for the patch !
It works fine for me:

Tested-by: Jean-Michel Hautbois <jeanmichel.hautbois@...eli.org>
> ---
>   arch/m68k/kernel/setup_mm.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/m68k/kernel/setup_mm.c b/arch/m68k/kernel/setup_mm.c
> index 15c1a595a1de..48ce67947678 100644
> --- a/arch/m68k/kernel/setup_mm.c
> +++ b/arch/m68k/kernel/setup_mm.c
> @@ -243,8 +243,7 @@ void __init setup_arch(char **cmdline_p)
>   	setup_initial_init_mm((void *)PAGE_OFFSET, _etext, _edata, _end);
>   
>   #if defined(CONFIG_BOOTPARAM)
> -	strncpy(m68k_command_line, CONFIG_BOOTPARAM_STRING, CL_SIZE);
> -	m68k_command_line[CL_SIZE - 1] = 0;
> +	strscpy(m68k_command_line, CONFIG_BOOTPARAM_STRING, CL_SIZE);
>   #endif /* CONFIG_BOOTPARAM */
>   	process_uboot_commandline(&m68k_command_line[0], CL_SIZE);
>   	*cmdline_p = m68k_command_line;