linux-kernel - Re: [PATCH v3] gpu: cdns-mhdp8546: fix call balance of mhdp->clk handling routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <173979808601.704013.18168573749410463976.b4-ty@kernel.org>
Date: Mon, 17 Feb 2025 14:14:46 +0100
From: Robert Foss <rfoss@...nel.org>
To: Andrzej Hajda <andrzej.hajda@...el.com>, 
 Vitalii Mordan <mordan@...ras.ru>
Cc: Neil Armstrong <neil.armstrong@...aro.org>, 
 Laurent Pinchart <Laurent.pinchart@...asonboard.com>, 
 Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>, 
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, 
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
 Sui Jingfeng <sui.jingfeng@...ux.dev>, 
 Aleksandr Mishin <amishin@...rgos.ru>, Al Viro <viro@...iv.linux.org.uk>, 
 Tomi Valkeinen <tomi.valkeinen@...com>, Jyri Sarha <jsarha@...com>, 
 Quentin Schulz <quentin.schulz@...e-electrons.com>, 
 Swapnil Jakhade <sjakhade@...ence.com>, dri-devel@...ts.freedesktop.org, 
 linux-kernel@...r.kernel.org, Fedor Pchelkin <pchelkin@...ras.ru>, 
 Alexey Khoroshilov <khoroshilov@...ras.ru>, 
 Vadim Mutilin <mutilin@...ras.ru>, lvc-project@...uxtesting.org
Subject: Re: [PATCH v3] gpu: cdns-mhdp8546: fix call balance of mhdp->clk
 handling routines

On Fri, 14 Feb 2025 18:46:32 +0300, Vitalii Mordan wrote:
> If the clock mhdp->clk was not enabled in cdns_mhdp_probe(), it should not
> be disabled in any path.
> 
> The return value of clk_prepare_enable() is not checked. If mhdp->clk was
> not enabled, it may be disabled in the error path of cdns_mhdp_probe()
> (e.g., if cdns_mhdp_load_firmware() fails) or in cdns_mhdp_remove() after
> a successful cdns_mhdp_probe() call.
> 
> [...]

Applied, thanks!

[1/1] gpu: cdns-mhdp8546: fix call balance of mhdp->clk handling routines
      https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/f65727be3fa5



Rob