linux-kernel - Re: [PATCH next] nfsd: Fix a WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f9642ccee115ba4b637609eb25a7540c6c4e449d.camel@kernel.org>
Date: Mon, 17 Feb 2025 08:47:08 -0500
From: Jeff Layton <jlayton@...nel.org>
To: Dan Carpenter <dan.carpenter@...aro.org>, Olga Kornievskaia
	 <okorniev@...hat.com>
Cc: Chuck Lever <chuck.lever@...cle.com>, Neil Brown <neilb@...e.de>, Dai
 Ngo	 <Dai.Ngo@...cle.com>, Tom Talpey <tom@...pey.com>,
 linux-nfs@...r.kernel.org, 	linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] nfsd: Fix a WARN_ONCE() message

On Mon, 2025-02-17 at 10:33 +0300, Dan Carpenter wrote:
> The first parameter of WARN_ONCE() is supposed to be the condition but
> it's missing here.  This WARN_ONCE() will only print the "xcl_name".
> 
> Fixes: 61b490d48618 ("nfsd: fix management of listener transports")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  fs/nfsd/nfsctl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
> index 2cd540b26965..ac265d6fde35 100644
> --- a/fs/nfsd/nfsctl.c
> +++ b/fs/nfsd/nfsctl.c
> @@ -2027,7 +2027,7 @@ int nfsd_nl_listener_set_doit(struct sk_buff *skb, struct genl_info *info)
>  		xprt = svc_find_listener(serv, xcl_name, net, sa);
>  		if (xprt) {
>  			if (delete)
> -				WARN_ONCE("Transport type=%s already exists\n",
> +				WARN_ONCE(1, "Transport type=%s already exists\n",
>  					  xcl_name);
>  			svc_xprt_put(xprt);
>  			continue;

Reviewed-by: Jeff Layton <jlayton@...nel.org>