linux-kernel - Re: [PATCH] crypto: bpf - Add MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <43fa75f9-e6e3-4d80-b3b0-a97387fb2a07@linux.dev>
Date: Mon, 17 Feb 2025 14:03:27 +0000
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Arnd Bergmann <arnd@...nel.org>, Herbert Xu
 <herbert@...dor.apana.org.au>, "David S. Miller" <davem@...emloft.net>,
 Martin KaFai Lau <martin.lau@...nel.org>
Cc: Arnd Bergmann <arnd@...db.de>, bpf@...r.kernel.org,
 linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: bpf - Add MODULE_DESCRIPTION for skcipher

On 17/02/2025 12:55, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> All modules should have a description, building with extra warnings
> enabled prints this outfor the for bpf_crypto_skcipher module:
> 
> WARNING: modpost: missing MODULE_DESCRIPTION() in crypto/bpf_crypto_skcipher.o
> 
> Add a description line.
> 
> Fixes: fda4f71282b2 ("bpf: crypto: add skcipher to bpf crypto")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>   crypto/bpf_crypto_skcipher.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/crypto/bpf_crypto_skcipher.c b/crypto/bpf_crypto_skcipher.c
> index b5e657415770..a88798d3e8c8 100644
> --- a/crypto/bpf_crypto_skcipher.c
> +++ b/crypto/bpf_crypto_skcipher.c
> @@ -80,3 +80,4 @@ static void __exit bpf_crypto_skcipher_exit(void)
>   module_init(bpf_crypto_skcipher_init);
>   module_exit(bpf_crypto_skcipher_exit);
>   MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("Symmetric key cipher support for BPF");

Thanks for fixing!

Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>