linux-kernel - Re: [PATCH v4 0/3] iio: light: add al3000a als support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250217143006.1f043a0e@jic23-huawei>
Date: Mon, 17 Feb 2025 14:30:06 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Svyatoslav Ryhel <clamor95@...il.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Thierry Reding <thierry.reding@...il.com>, Jonathan
 Hunter <jonathanh@...dia.com>, Javier Carrasco
 <javier.carrasco.cruz@...il.com>, Matti Vaittinen
 <mazziesaccount@...il.com>, Andy Shevchenko
 <andriy.shevchenko@...ux.intel.com>, Emil Gedenryd
 <emil.gedenryd@...s.com>, Arthur Becker <arthur.becker@...tec.com>, Mudit
 Sharma <muditsharma.info@...il.com>, Per-Daniel Olsson
 <perdaniel.olsson@...s.com>, Subhajit Ghosh
 <subhajit.ghosh@...aklogic.com>, Ivan Orlov <ivan.orlov0322@...il.com>,
 David Heidelberg <david@...t.cz>, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-tegra@...r.kernel.org
Subject: Re: [PATCH v4 0/3] iio: light: add al3000a als support

On Mon, 17 Feb 2025 16:03:33 +0200
Svyatoslav Ryhel <clamor95@...il.com> wrote:

> AL3000a is an illuminance sensor found in ASUS TF101 tablet.
Hi Svyatoslav,

Just a small request.  Please reduce rate of sending new versions.
That tends to give time for discussions on earlier versions to progress
and for more reviewers to see the current version.

I'd suggest at least 3-4 days between versions.  It's great to
responsive to reviewers of course!

Jonathan


> 
> ---
> Changes on switching from v3 to v4:
> - return write function directly
> - clean up and fix i2c_device_id
> 
> Changes on switching from v2 to v3:
> - droped linux/iio/sysfs.h
> - set driver name directly
> - switched to IIO_CHAN_INFO_PROCESSED
> - split al3000a_set_pwr into 2 functions
> - added i2c_device_id
> - improved code formatting 
> 
> Changes on switching from v1 to v2:
> - sort compatible alphabetically in schema
> - clarify commit descriptions
> - convert to use regmap
> - arrangle lux conversion table in rows of 8
> - add more used headers
> - improve code formatting 
> ---
> 
> Svyatoslav Ryhel (3):
>   dt-bindings: iio: light: al3010: add al3000a support
>   iio: light: Add support for AL3000a illuminance sensor
>   ARM: tegra: tf101: Add al3000a illuminance sensor node
> 
>  .../bindings/iio/light/dynaimage,al3010.yaml  |   6 +-
>  .../boot/dts/nvidia/tegra20-asus-tf101.dts    |  11 +
>  drivers/iio/light/Kconfig                     |  10 +
>  drivers/iio/light/Makefile                    |   1 +
>  drivers/iio/light/al3000a.c                   | 209 ++++++++++++++++++
>  5 files changed, 235 insertions(+), 2 deletions(-)
>  create mode 100644 drivers/iio/light/al3000a.c
>