linux-kernel - Re: [PATCH 3/5] reset: imx8mp-audiomix: Introduce active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250218151127.GB6537@nxa18884-linux>
Date: Tue, 18 Feb 2025 23:11:27 +0800
From: Peng Fan <peng.fan@....nxp.com>
To: Daniel Baluta <daniel.baluta@....com>
Cc: p.zabel@...gutronix.de, shawnguo@...nel.org, mathieu.poirier@...aro.org,
	s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
	imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, andersson@...nel.org,
	linux-remoteproc@...r.kernel.org, iuliana.prodan@....com,
	laurentiu.mihalcea@....com, shengjiu.wang@....com, Frank.Li@....com,
	krzk@...nel.org
Subject: Re: [PATCH 3/5] reset: imx8mp-audiomix: Introduce active_low
 configuration option

On Tue, Feb 18, 2025 at 10:57:10AM +0200, Daniel Baluta wrote:
>For EARC and EARC PHY the reset happens when clearing the reset bits.
>Refactor assert/deassert function in order to take into account
>the active_low configuratin option.
>
>Signed-off-by: Daniel Baluta <daniel.baluta@....com>
>---
> drivers/reset/reset-imx8mp-audiomix.c | 45 ++++++++++++++-------------
> 1 file changed, 23 insertions(+), 22 deletions(-)
>
>diff --git a/drivers/reset/reset-imx8mp-audiomix.c b/drivers/reset/reset-imx8mp-audiomix.c
>index 6b1666c4e069..8cc0a6b58cbc 100644
>--- a/drivers/reset/reset-imx8mp-audiomix.c
>+++ b/drivers/reset/reset-imx8mp-audiomix.c
>@@ -23,16 +23,19 @@
> struct imx8mp_reset_map {
> 	unsigned int offset;
> 	unsigned int mask;
>+	bool active_low;

How about using u32 flags?
Then it will be easy to extend to add new FLAG in future in case.

If you tend to use bool, also ok to me:

Reviewed-by: Peng Fan <peng.fan@....com>