linux-kernel - Re: [PATCH] nfsd: decrease cl_cb_inflight if fail to queue cb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <173988860071.5368.16253954106532190789.b4-ty@oracle.com>
Date: Tue, 18 Feb 2025 09:24:02 -0500
From: cel@...nel.org
To: jlayton@...nel.org,
	neilb@...e.de,
	okorniev@...hat.com,
	Dai.Ngo@...cle.com,
	tom@...pey.com,
	linux-nfs@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Li Lingfeng <lilingfeng3@...wei.com>
Cc: Chuck Lever <chuck.lever@...cle.com>,
	yukuai1@...weicloud.com,
	houtao1@...wei.com,
	yi.zhang@...wei.com,
	yangerkun@...wei.com,
	lilingfeng@...weicloud.com
Subject: Re: [PATCH] nfsd: decrease cl_cb_inflight if fail to queue cb_work

From: Chuck Lever <chuck.lever@...cle.com>

On Tue, 18 Feb 2025 21:54:23 +0800, Li Lingfeng wrote:
> In nfsd4_run_cb, cl_cb_inflight is increased before attempting to queue
> cb_work to callback_wq. This count can be decreased in three situations:
> 1) If queuing fails in nfsd4_run_cb, the count will be decremented
> accordingly.
> 2) After cb_work is running, the count is decreased in the exception
> branch of nfsd4_run_cb_work via nfsd41_destroy_cb.
> 3) The count is decreased in the release callback of rpc_task — either
> directly calling nfsd41_cb_inflight_end in nfsd4_cb_probe_release, or
> calling nfsd41_destroy_cb in nfsd4_cb_release.
> 
> [...]

Applied to nfsd-testing, thanks!

[1/1] nfsd: decrease cl_cb_inflight if fail to queue cb_work
      commit: bcf482e3b1f4e622c6a1bfa971cd8035227b8b56

--
Chuck Lever