linux-kernel - Re: [PATCH v2 05/13] clk: renesas: Pass sub struct of cpg_mssr_priv to cpg_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdXAfrLOFFbt63tJvU_g08zCR_QBQQMzUz-Ceg=G5FQnOA@mail.gmail.com>
Date: Tue, 18 Feb 2025 15:28:26 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Thierry Bultel <thierry.bultel.yh@...renesas.com>
Cc: thierry.bultel@...atsea.fr, Michael Turquette <mturquette@...libre.com>, 
	Stephen Boyd <sboyd@...nel.org>, linux-renesas-soc@...r.kernel.org, 
	linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 05/13] clk: renesas: Pass sub struct of cpg_mssr_priv
 to cpg_clk_register

Hi Thierry,

On Mon, 17 Feb 2025 at 11:54, Thierry Bultel
<thierry.bultel.yh@...renesas.com> wrote:
> In a coming evolution, the registration callback will need more parameters
> from cpg_mssr_priv (like another base address with clock controllers
> with double register block).
> Instead of adding more parameters, mode the needed parameters to a public
> sub-struct.

No SoB?

>  drivers/clk/renesas/r7s9210-cpg-mssr.c  |  7 +-
>  drivers/clk/renesas/r8a77970-cpg-mssr.c | 11 +--
>  drivers/clk/renesas/rcar-gen3-cpg.c     |  8 +-
>  drivers/clk/renesas/rcar-gen3-cpg.h     |  6 +-
>  drivers/clk/renesas/rcar-gen4-cpg.c     |  9 ++-
>  drivers/clk/renesas/rcar-gen4-cpg.h     |  3 +-
>  drivers/clk/renesas/renesas-cpg-mssr.c  | 99 +++++++++++++------------
>  drivers/clk/renesas/renesas-cpg-mssr.h  | 21 +++++-
>  8 files changed, 93 insertions(+), 71 deletions(-)

As you forgot to update drivers/clk/renesas/rcar-gen2-cpg.[ch], this
breaks the build for R-Car Gen2 and RZ/G1 (e.g. shmobile_defconfig),

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds