linux-kernel - Re: [PATCH 1/6] x86/microcode: Introduce staging option to reduce late-loading latency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5ed90792-ba64-476a-ad7c-6fdba7af3df1@intel.com>
Date: Tue, 18 Feb 2025 07:16:25 -0800
From: Dave Hansen <dave.hansen@...el.com>
To: "Chang S. Bae" <chang.seok.bae@...el.com>, linux-kernel@...r.kernel.org
Cc: x86@...nel.org, tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
 dave.hansen@...ux.intel.com
Subject: Re: [PATCH 1/6] x86/microcode: Introduce staging option to reduce
 late-loading latency

On 12/10/24 17:42, Chang S. Bae wrote:
> +	if (microcode_ops->use_staging)
> +		microcode_ops->stage_microcode();

I don't know if any non-Intel vendors will implement one of these, but
could we please comment this a _bit_?

Somebody is going to come along at some point and ask themselves whether
they should add a new staging handler or dump some new code in an
existing one. The key aspects of the existing staging handler are:

	1. Helps the future actual microcode load in some way
	2. Has little impact on the rest of the system
	3. Can succeed or fail without affecting functionality

Did I miss any?

Could we add a comment here, or maybe even at the Intel
stage_microcode() function explaining this intent?