linux-kernel - Re: [PATCH v17 0/3] rust: xarray: Add a minimal abstraction for XArray

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z7SlefHJtpZFzV6t@pollux>
Date: Tue, 18 Feb 2025 16:21:29 +0100
From: Danilo Krummrich <dakr@...nel.org>
To: Tamir Duberstein <tamird@...il.com>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Benno Lossin <benno.lossin@...ton.me>,
	Andreas Hindborg <a.hindborg@...nel.org>,
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
	Matthew Wilcox <willy@...radead.org>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	FUJITA Tomonori <fujita.tomonori@...il.com>,
	"Rob Herring (Arm)" <robh@...nel.org>,
	Maíra Canal <mcanal@...lia.com>,
	Asahi Lina <lina@...hilina.net>, rust-for-linux@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-pci@...r.kernel.org
Subject: Re: [PATCH v17 0/3] rust: xarray: Add a minimal abstraction for
 XArray

On Tue, Feb 18, 2025 at 09:37:42AM -0500, Tamir Duberstein wrote:
> Changes in v17:

> - Drop patch "rust: remove redundant `as _` casts". (Danilo Krummrich)

Just to clarify, I did not suggest to drop the patch, but rather move it after
patch 1 ("rust: types: add `ForeignOwnable::PointedTo`").

Instead you proposed to make this a good first issue, which is fine too.

> - Drop trailers for shared commit from configfs series[0]. (Danilo
>   Krummrich)

Clarifying further, I pointed out that it's worth to consider dropping them when
making subsequent changes that haven't been discussed on the list and are not
listed in the change log (e.g. because they seem minor).

This was an expression of opinion, not a request.

> - Avoid shadowing expressions with .cast() calls. (Danilo Krummrich)

I appreciate that, thanks!