linux-kernel - Re: [PATCH v2 17/29] ASoC: tas2764: Crop SDOUT zero-out mask based on BCLK ratio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <6553EEBD-B64F-4985-8CC6-2BBA7B6AAC91@cutebit.org>
Date: Tue, 18 Feb 2025 16:55:04 +0100
From: Martin Povišer <povik+lin@...ebit.org>
To: James Calligeros <jcalligeros99@...il.com>
Cc: Mark Brown <broonie@...nel.org>,
 linux-sound@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org,
 asahi@...ts.linux.dev,
 linux-hwmon@...r.kernel.org
Subject: Re: [PATCH v2 17/29] ASoC: tas2764: Crop SDOUT zero-out mask based on
 BCLK ratio


> On 18. 2. 2025, at 16:25, Mark Brown <broonie@...nel.org> wrote:
> 
> On Tue, Feb 18, 2025 at 06:35:51PM +1000, James Calligeros wrote:
>> From: Martin Povišer <povik+lin@...ebit.org>
>> 
>> Reviewed-by: Neal Gompa <neal@...pa.dev>
>> Signed-off-by: Martin Povišer <povik+lin@...ebit.org>
>> Signed-off-by: James Calligeros <jcalligeros99@...il.com>
> 
> Again, why do this?  Is this a bug fix of some kind (ie, does the
> hardware misbehave if we get this wrong) or is it just for neatness?

James,

I’ve found the language in the datasheet which made me make this change:

"This register to be programmed as zero in case the slot is not valid as per valid FSRATIO”

Martin