linux-kernel - Re: [PATCH] nvme: remove multipath module parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <03bd60e5-7c7b-4589-a71a-a48ff53a619c@redhat.com>
Date: Tue, 18 Feb 2025 11:41:56 -0500
From: John Meneghini <jmeneghi@...hat.com>
To: Bryan Gurney <bgurney@...hat.com>, linux-kernel@...r.kernel.org,
 linux-nvme@...ts.infradead.org, kbusch@...nel.org, hch@....de,
 sagi@...mberg.me, axboe@...nel.dk
Cc: bmarzins@...hat.com
Subject: Re: [PATCH] nvme: remove multipath module parameter

On 2/18/25 9:26 AM, John Meneghini wrote:
>> +    } else {
>> +#ifdef CONFIG_NVME_MULTIPATH
>>           sprintf(disk->disk_name, "nvme%dn%d", ctrl->subsys->instance,
>>               ns->head->instance);
>> -    } else {
>  > +#else
> 
> You don't need the this #ifdef conditional statement because the nvme_ns_head_multipath() function checks CONFIG_NVME_MULTIPATH
> for you and the sprintf(disk->disk_name, "nvme%dn%d" statement is kind of redundant.
> 
> 
>>           sprintf(disk->disk_name, "nvme%dn%d", ctrl->instance,
>>               ns->head->instance);
>> +#endif 

Actually, I think I may be wrong about this.  To maintain 100% backward compatibility with what the users see in the dmesg log, I think we need this code.

/John