| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAJ-ks9kyozt45VeXG7GBTN-ejy_HGMOekFYFMmzS8AbEusZMWQ@mail.gmail.com>
Date: Tue, 18 Feb 2025 12:05:21 -0500
From: Tamir Duberstein <tamird@...il.com>
To: Michal Rostecki <vadorovsky@...tonmail.com>, Miguel Ojeda <ojeda@...nel.org>,
Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>,
Gary Guo <gary@...yguo.net>, Björn Roy Baron <bjorn3_gh@...tonmail.com>,
Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>,
Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>
Cc: rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 0/4] rust: replace kernel::str::CStr w/ core::ffi::CStr
Gentle ping. Trevor, Alice, Benno: you all participated in the last
round of review - I'd appreciate it if you could take a look at this
series.
Cheers.
Tamir
On Mon, Feb 3, 2025 at 6:50 AM Tamir Duberstein <tamird@...il.com> wrote:
>
> This picks up from Michal Rostecki's work[0]. Per Michal's guidance I
> have omitted Co-authored tags, as the end result is quite different.
>
> Link: https://lore.kernel.org/rust-for-linux/20240819153656.28807-2-vadorovsky@protonmail.com/t/#u [0]
> Closes: https://github.com/Rust-for-Linux/linux/issues/1075
>
> Signed-off-by: Tamir Duberstein <tamird@...il.com>
> ---
> Changes in v8:
> - Move `{from,as}_char_ptr` back to `CStrExt`. This reduces the diff
> some.
> - Restore `from_bytes_with_nul_unchecked_mut`, `to_cstring`.
> - Link to v7: https://lore.kernel.org/r/20250202-cstr-core-v7-0-da1802520438@gmail.com
>
> Changes in v7:
> - Rebased on mainline.
> - Restore functionality added in commit a321f3ad0a5d ("rust: str: add
> {make,to}_{upper,lower}case() to CString").
> - Used `diff.algorithm patience` to improve diff readability.
> - Link to v6: https://lore.kernel.org/r/20250202-cstr-core-v6-0-8469cd6d29fd@gmail.com
>
> Changes in v6:
> - Split the work into several commits for ease of review.
> - Restore `{from,as}_char_ptr` to allow building on ARM (see commit
> message).
> - Add `CStrExt` to `kernel::prelude`. (Alice Ryhl)
> - Remove `CStrExt::from_bytes_with_nul_unchecked_mut` and restore
> `DerefMut for CString`. (Alice Ryhl)
> - Rename and hide `kernel::c_str!` to encourage use of C-String
> literals.
> - Drop implementation and invocation changes in kunit.rs. (Trevor Gross)
> - Drop docs on `Display` impl. (Trevor Gross)
> - Rewrite docs in the style of the standard library.
> - Restore the `test_cstr_debug` unit tests to demonstrate that the
> implementation has changed.
>
> Changes in v5:
> - Keep the `test_cstr_display*` unit tests.
>
> Changes in v4:
> - Provide the `CStrExt` trait with `display()` method, which returns a
> `CStrDisplay` wrapper with `Display` implementation. This addresses
> the lack of `Display` implementation for `core::ffi::CStr`.
> - Provide `from_bytes_with_nul_unchecked_mut()` method in `CStrExt`,
> which might be useful and is going to prevent manual, unsafe casts.
> - Fix a typo (s/preffered/prefered/).
>
> Changes in v3:
> - Fix the commit message.
> - Remove redundant braces in `use`, when only one item is imported.
>
> Changes in v2:
> - Do not remove `c_str` macro. While it's preferred to use C-string
> literals, there are two cases where `c_str` is helpful:
> - When working with macros, which already return a Rust string literal
> (e.g. `stringify!`).
> - When building macros, where we want to take a Rust string literal as an
> argument (for caller's convenience), but still use it as a C-string
> internally.
> - Use Rust literals as arguments in macros (`new_mutex`, `new_condvar`,
> `new_mutex`). Use the `c_str` macro to convert these literals to C-string
> literals.
> - Use `c_str` in kunit.rs for converting the output of `stringify!` to a
> `CStr`.
> - Remove `DerefMut` implementation for `CString`.
>
> ---
> Tamir Duberstein (4):
> rust: move BStr,CStr Display impls behind method
> rust: replace `CStr` with `core::ffi::CStr`
> rust: replace `kernel::c_str!` with C-Strings
> rust: remove core::ffi::CStr reexport
>
> drivers/net/phy/ax88796b_rust.rs | 7 +-
> drivers/net/phy/qt2025.rs | 5 +-
> rust/kernel/device.rs | 7 +-
> rust/kernel/devres.rs | 2 +-
> rust/kernel/driver.rs | 4 +-
> rust/kernel/error.rs | 10 +-
> rust/kernel/firmware.rs | 7 +-
> rust/kernel/kunit.rs | 18 +-
> rust/kernel/lib.rs | 2 +-
> rust/kernel/miscdevice.rs | 5 +-
> rust/kernel/net/phy.rs | 8 +-
> rust/kernel/of.rs | 5 +-
> rust/kernel/pci.rs | 3 +-
> rust/kernel/platform.rs | 7 +-
> rust/kernel/prelude.rs | 2 +-
> rust/kernel/seq_file.rs | 4 +-
> rust/kernel/str.rs | 542 +++++++++++++----------------------
> rust/kernel/sync.rs | 4 +-
> rust/kernel/sync/condvar.rs | 3 +-
> rust/kernel/sync/lock.rs | 4 +-
> rust/kernel/sync/lock/global.rs | 6 +-
> rust/kernel/sync/poll.rs | 1 +
> rust/kernel/workqueue.rs | 1 +
> rust/macros/module.rs | 2 +-
> samples/rust/rust_driver_pci.rs | 4 +-
> samples/rust/rust_driver_platform.rs | 4 +-
> samples/rust/rust_misc_device.rs | 3 +-
> 27 files changed, 268 insertions(+), 402 deletions(-)
> ---
> base-commit: 8b3f2116ea4a9521f852b7f9d1d6dd4d7ad86810
> change-id: 20250201-cstr-core-d4b9b69120cf
>
> Best regards,
> --
> Tamir Duberstein <tamird@...il.com>
>
Powered by blists - more mailing lists