linux-kernel - Re: [PATCH v4] ACPI: HED: Always initialize before evged

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0hK4fB2oh14L=_qqBAL9vhar-4WuvP1bmnF9XwRrG9+NQ@mail.gmail.com>
Date: Tue, 18 Feb 2025 19:26:21 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Xiaofei Tan <tanxiaofei@...wei.com>
Cc: rafael@...nel.org, lenb@...nel.org, linux-acpi@...r.kernel.org, 
	linux-kernel@...r.kernel.org, jonathan.cameron@...wei.com, 
	mchehab+huawei@...nel.org, roberto.sassu@...wei.com, shiju.jose@...wei.com, 
	prime.zeng@...ilicon.com, linuxarm@...wei.com
Subject: Re: [PATCH v4] ACPI: HED: Always initialize before evged

On Wed, Feb 12, 2025 at 7:41 AM Xiaofei Tan <tanxiaofei@...wei.com> wrote:
>
> When the module HED is built-in, the module HED init is behind EVGED
> as the driver are in the same initcall level, then the order is determined
> by Makefile order. That order violates expectations. Because RAS records
> can't be handled in the special time window that EVGED has initialized
> while HED not.
>
> If the number of such RAS records is more than the APEI HEST error source
> number, the HEST resources could be occupied all, and then could affect
> subsequent RAS error reporting.
>
> Change the initcall level of HED to subsys_init to fix the issue. If build
> HED as a module, the problem remains. To solve this problem completely,
> change the ACPI_HED from tristate to bool.
>
> Signed-off-by: Xiaofei Tan <tanxiaofei@...wei.com>
> ---
>  -v4: Fix register HED device twice issue found by Nathan, and change
> patch name following Rafael's advice.
> ---
>  drivers/acpi/Kconfig | 2 +-
>  drivers/acpi/hed.c   | 7 ++++++-
>  2 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> index d81b55f5068c..7f10aa38269d 100644
> --- a/drivers/acpi/Kconfig
> +++ b/drivers/acpi/Kconfig
> @@ -452,7 +452,7 @@ config ACPI_SBS
>           the modules will be called sbs and sbshc.
>
>  config ACPI_HED
> -       tristate "Hardware Error Device"
> +       bool "Hardware Error Device"
>         help
>           This driver supports the Hardware Error Device (PNP0C33),
>           which is used to report some hardware errors notified via
> diff --git a/drivers/acpi/hed.c b/drivers/acpi/hed.c
> index 7652515a6be1..3499f86c411e 100644
> --- a/drivers/acpi/hed.c
> +++ b/drivers/acpi/hed.c
> @@ -80,7 +80,12 @@ static struct acpi_driver acpi_hed_driver = {
>                 .remove = acpi_hed_remove,
>         },
>  };
> -module_acpi_driver(acpi_hed_driver);
> +
> +static int __init acpi_hed_driver_init(void)
> +{
> +       return acpi_bus_register_driver(&acpi_hed_driver);
> +}
> +subsys_initcall(acpi_hed_driver_init);
>
>  MODULE_AUTHOR("Huang Ying");
>  MODULE_DESCRIPTION("ACPI Hardware Error Device Driver");
> --

Applied as 6.15 material with changelog edits, thanks!