linux-kernel - Re: [PATCH] objtool: Use idiomatic section name for relocatable rodata under PIE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250218183108.anuqoojsgkjxwfai@jpoimboe>
Date: Tue, 18 Feb 2025 10:31:08 -0800
From: Josh Poimboeuf <jpoimboe@...nel.org>
To: Ard Biesheuvel <ardb@...nel.org>
Cc: Ard Biesheuvel <ardb+git@...gle.com>, linux-kernel@...r.kernel.org,
	x86@...nel.org, Huacai Chen <chenhuacai@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Tiezhu Yang <yangtiezhu@...ngson.cn>
Subject: Re: [PATCH] objtool: Use idiomatic section name for relocatable
 rodata under PIE

On Tue, Feb 18, 2025 at 06:44:23PM +0100, Ard Biesheuvel wrote:
> > If I understand correctly, this is fixing an existing bug in loongarch
> > and any other arches using PIE, right?
> 
> There are no other arches using PIE as far as I know. But it indeed
> fixes an oversight in how -fPIE is used in the kernel.
> 
> > And it has nothing to do with
> > objtool?
> >
> 
> That didn't stop you from taking the previous fix :-)

The whole point of the previous fix was to fix a bug in the objtool
annotations.  Unlike your patch, it didn't have any intended side
effects.

> > If so, it feels like this needs to be its own patch, described as a fix.
> >
> 
> Fair enough. But better to drop the previous patch from the objtool tree then.

I think we can do that... Peter?

And just to be clear, you'll have two fixes, right?

  1) Make loongarch .data.rel.ro.* actually read-only
  2) Fix objtool C jump table annotations for clang

-- 
Josh