linux-kernel - Re: [PATCH net-next v3] af_unix: Fix undefined 'other' error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250218183922.25318-1-kuniyu@amazon.com>
Date: Tue, 18 Feb 2025 10:39:22 -0800
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <purvayeshi550@...il.com>
CC: <davem@...emloft.net>, <edumazet@...gle.com>, <horms@...nel.org>,
	<kuba@...nel.org>, <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
	<pabeni@...hat.com>, <skhan@...uxfoundation.org>, Kuniyuki Iwashima
	<kuniyu@...zon.com>
Subject: Re: [PATCH net-next v3] af_unix: Fix undefined 'other' error

From: Purva Yeshi <purvayeshi550@...il.com>
Date: Tue, 18 Feb 2025 19:40:45 +0530
> Fix an issue detected by the Smatch static analysis tool where an
> "undefined 'other'" error occurs due to `__releases(&unix_sk(other)->lock)`
> being placed before 'other' is in scope.

I don't care much, but according to Dan, this is Sparse error due to
const unix_sk() ?

https://lore.kernel.org/all/bbf51850-814a-4a30-8165-625d88f221a5@stanley.mountain/

> 
> Remove the `__releases()` annotation from the `unix_wait_for_peer()`
> function to eliminate the Smatch warning. The annotation references `other`

Same here ?


> before it is declared, leading to a false positive error during static
> analysis.
> 
> Since AF_UNIX does not use Sparse annotations, this annotation is
> unnecessary and does not impact functionality.
> 
> Signed-off-by: Purva Yeshi <purvayeshi550@...il.com>

Anyway,

Reviewed-by: Kuniyuki Iwashima <kuniyu@...zon.com>

Also, I think you can carry over Joe and Simon's tags as the change is
trivial.