linux-kernel - Re: [RFC PATCH V2 1/2] mmc: Update sdhci tune function to return errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250218184112.574772-1-erick.shepherd@ni.com>
Date: Tue, 18 Feb 2025 12:41:12 -0600
From: Erick Shepherd <erick.shepherd@...com>
To: <adrian.hunter@...el.com>
CC: <andy-ld.lu@...iatek.com>, <avri.altman@....com>, <cw9316.lee@...sung.com>,
        <dsimic@...jaro.org>, <erick.shepherd@...com>, <keita.aihara@...y.com>,
        <linux-kernel@...r.kernel.org>, <linux-mmc@...r.kernel.org>,
        <quic_jjohnson@...cinc.com>, <ricardo@...liere.net>,
        <ulf.hansson@...aro.org>, <victor.shih@...esyslogic.com.tw>,
        <wsa+renesas@...g-engineering.com>
Subject: Re: [RFC PATCH V2 1/2] mmc: Update sdhci tune function to return errors

I see, in my case intel_execute_tuning() in sdhci-pci-core.c is what
is calling into sdhci_execute_tuning() so I should check the value of
tuning_err there and possibly return it? The issue I'm trying to solve
is only for DDR50 cards that do not support tuning so I could
conditionally return tuning_err if the timing mode is DDR50. Maybe
something like this?

---
 drivers/mmc/host/sdhci-pci-core.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
index 1f0bd723f011..9aedb476bd5d 100644
--- a/drivers/mmc/host/sdhci-pci-core.c
+++ b/drivers/mmc/host/sdhci-pci-core.c
@@ -725,6 +725,9 @@ static int intel_execute_tuning(struct mmc_host *mmc, u32 opcode)
 	if (err)
 		return err;
 
+	if (host->tuning_err && mmc->ios.timing == MMC_TIMING_UHS_DDR50)
+		return host->tuning_err;
+
 	/*
 	 * Tuning can leave the IP in an active state (Buffer Read Enable bit
 	 * set) which prevents the entry to low power states (i.e. S0i3). Data
-- 

Regards
Erick