linux-kernel - Re: [PATCH sched_ext/for-6.15] sched_ext: idle: Introduce node-aware idle cpu kfunc helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z7TbRNkC4xQiUDLa@slm.duckdns.org>
Date: Tue, 18 Feb 2025 09:11:00 -1000
From: Tejun Heo <tj@...nel.org>
To: Yury Norov <yury.norov@...il.com>
Cc: Andrea Righi <arighi@...dia.com>, David Vernet <void@...ifault.com>,
	Changwoo Min <changwoo@...lia.com>,
	Joel Fernandes <joelagnelf@...dia.com>, Ian May <ianm@...dia.com>,
	bpf@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH sched_ext/for-6.15] sched_ext: idle: Introduce node-aware
 idle cpu kfunc helpers

On Tue, Feb 18, 2025 at 02:09:41PM -0500, Yury Norov wrote:
> On Tue, Feb 18, 2025 at 09:01:54AM -1000, Tejun Heo wrote:
> > On Tue, Feb 18, 2025 at 07:04:41PM +0100, Andrea Righi wrote:
> > > Introduce a new kfunc to retrieve the node associated to a CPU:
> > > 
> > >  int scx_bpf_cpu_node(s32 cpu)
> > > 
> > > Add the following kfuncs to provide BPF schedulers direct access to
> > > per-node idle cpumasks information:
> > > 
> > >  const struct cpumask *scx_bpf_get_idle_cpumask_node(int node)
> > >  const struct cpumask *scx_bpf_get_idle_smtmask_node(int node)
> > >  s32 scx_bpf_pick_idle_cpu_node(const cpumask_t *cpus_allowed,
> > >  				int node, u64 flags)
> > >  s32 scx_bpf_pick_any_cpu_node(const cpumask_t *cpus_allowed,
> > >  			       int node, u64 flags)
> > > 
> > > Moreover, trigger an scx error when any of the non-node aware idle CPU
> > > kfuncs are used when SCX_OPS_BUILTIN_IDLE_PER_NODE is enabled.
> > > 
> > > Cc: Yury Norov [NVIDIA] <yury.norov@...il.com>
> > > Signed-off-by: Andrea Righi <arighi@...dia.com>
> > 
> > Applied to sched_ext/for-6.15.
> 
> I added my review-by in v12. Can you please add it here?
> 
> Reviewed-by: Yury Norov [NVIDIA] <yury.norov@...il.com>

Okay, updated.

Thanks.

-- 
tejun