linux-kernel - Re: [PATCH 0/2] tools: Unify top-level quiet infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z7TbUbs4nvuLF-rq@x1>
Date: Tue, 18 Feb 2025 20:11:13 +0100
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc: Charlie Jenkins <charlie@...osinc.com>,
	Alexei Starovoitov <alexei.starovoitov@...il.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Alexei Starovoitov <ast@...nel.org>,
	Daniel Borkmann <daniel@...earbox.net>,
	Andrii Nakryiko <andrii@...nel.org>,
	Martin KaFai Lau <martin.lau@...ux.dev>,
	Eduard Zingerman <eddyz87@...il.com>, Song Liu <song@...nel.org>,
	Yonghong Song <yonghong.song@...ux.dev>,
	John Fastabend <john.fastabend@...il.com>,
	KP Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>,
	Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>, Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Ian Rogers <irogers@...gle.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Quentin Monnet <qmo@...nel.org>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Daniel Lezcano <daniel.lezcano@...aro.org>,
	Zhang Rui <rui.zhang@...el.com>, Lukasz Luba <lukasz.luba@....com>,
	Josh Poimboeuf <jpoimboe@...nel.org>,
	Mykola Lysenko <mykolal@...com>, Shuah Khan <shuah@...nel.org>,
	Jiri Kosina <jikos@...nel.org>,
	Benjamin Tissoires <bentiss@...nel.org>,
	Steven Rostedt <rostedt@...dmis.org>, bpf <bpf@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"linux-perf-use." <linux-perf-users@...r.kernel.org>,
	Linux Power Management <linux-pm@...r.kernel.org>,
	"open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@...r.kernel.org>,
	"open list:HID CORE LAYER" <linux-input@...r.kernel.org>,
	linux-trace-kernel <linux-trace-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/2] tools: Unify top-level quiet infrastructure

On Tue, Feb 18, 2025 at 07:39:44PM +0100, Arnaldo Carvalho de Melo wrote:
> On Mon, Feb 10, 2025 at 04:23:49PM -0800, Andrii Nakryiko wrote:
> > On Mon, Feb 10, 2025 at 10:31 AM Charlie Jenkins <charlie@...osinc.com> wrote:
> > > On Wed, Feb 05, 2025 at 05:28:19PM -0800, Andrii Nakryiko wrote:
> > > > On Tue, Feb 4, 2025 at 3:24 PM Charlie Jenkins <charlie@...osinc.com> wrote:
> > > > So, can you please check and fix?

> > > I think I am misunderstanding what you are saying. The patch that we are
> > > discussing on is the patch to fix this? You are showing the output from
> > > the patch that is being fixed in this series.

> > Ah, it's me getting confused. It was the earlier perf commit that
> > broke all this, makes sense. I just double-checked with your patches
> > applied locally. It indeed fixes the issue, LGTM.

> > Acked-by: Andrii Nakryiko <andrii@...nel.org>

> Thanks, b4 didn't pick this one, probably because you provided the Ack
> for a previous version of this series, but the patch in it is the same
> as in v2, so I'm keeping it, ok?

> Also since you applied the patches and tested it, can I promote the tag
> to Tested-by you?

> Humm, there is a slight difference, checking that in the e-mails
> thread...

> +  quiet = quiet_
> +  Q = @
> 
> The above doesn´t  have spaces surrounding the = sign, lemme see...

Got it, the comment about consistency, etc.

Can I use the Tested-by: for the v3 series?

- Arnaldo