linux-kernel - Re: [PATCH v4 1/3] HID: hid-appletb-kbd: simplify logic used to switch between media and function keys on pressing fn key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4n0465n0-r590-66p4-o4oq-56q1qn6rs2s1@xreary.bet>
Date: Tue, 18 Feb 2025 20:57:23 +0100 (CET)
From: Jiri Kosina <jikos@...nel.org>
To: Aditya Garg <gargaditya08@...e.com>
cc: Benjamin Tissoires <benjamin.tissoires@...hat.com>, 
    "bentiss@...nel.org" <bentiss@...nel.org>, 
    Dan Carpenter <dan.carpenter@...aro.org>, 
    Orlando Chamberlain <orlandoch.dev@...il.com>, 
    Kerem Karabay <kekrby@...il.com>, 
    "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>, 
    Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 1/3] HID: hid-appletb-kbd: simplify logic used to
 switch between media and function keys on pressing fn key

On Mon, 17 Feb 2025, Aditya Garg wrote:

> From: Aditya Garg <gargaditya08@...e.com>
> 
> This commit simplifies the logic in appletb_kbd_inp_event used for
> switching between the media and function keys on pressing the fn key.
> 
> We now also prevent touching the kbd->saved_mode variable in case the esc
> key only mode is chosen.
> 
> The following small fixes have also been done in this patch:
> 
> - A small comment style error has been fixed
> - Fixed spelling in MODULE_DESCRIPTION
> - I have added myself to MODULE_AUTHOR
> 
> Signed-off-by: Aditya Garg <gargaditya08@...e.com>

What a flood of patchseries :) I don't see any mentions on what are the 
v1->v2->v3->v4 changes, could you please document that?

-- 
Jiri Kosina
SUSE Labs