linux-kernel - Re: [PATCH v3] docs: iostats: Rewrite intro, remove outdated formats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ldu3ngh9.fsf@trenco.lwn.net>
Date: Tue, 18 Feb 2025 13:30:10 -0700
From: Jonathan Corbet <corbet@....net>
To: David Reaver <me@...idreaver.com>
Cc: David Reaver <me@...idreaver.com>, Randy Dunlap <rdunlap@...radead.org>,
 Jens Axboe <axboe@...nel.dk>, Konstantin Khlebnikov <koct9i@...il.com>,
 linux-doc@...r.kernel.org, linux-block@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] docs: iostats: Rewrite intro, remove outdated formats

David Reaver <me@...idreaver.com> writes:

> The introduction discussed stat file formats for very old kernel versions,
> which obscured key information that readers may find useful. Additionally,
> the example file contents and the reference to "15 fields" did not account
> for the flush fields added in b6866318657 ("block: add iostat counters for
> flush requests") [1].
>
> Rewrite the introduction to focus only on the current kernel's disk I/O stat
> file formats. Also, clean up wording for conciseness.
>
> Link: https://lore.kernel.org/lkml/157433282607.7928.5202409984272248322.stgit@buzz/T/ [1]
>
> Signed-off-by: David Reaver <me@...idreaver.com>
> ---
>
> Lore links to previous versions:
> V1: https://lore.kernel.org/linux-doc/20250214013905.60526-1-me@davidreaver.com/
> V2: https://lore.kernel.org/linux-doc/20250214051432.207630-1-me@davidreaver.com/
>
> Changes:
> V1 -> V2: Rewrite entire introduction instead of just changing 15 -> 17.
> V2 -> V3: Reword counter reset paragraph for accuracy and clarity.
>
>  Documentation/admin-guide/iostats.rst | 89 ++++++++++-----------------
>  1 file changed, 33 insertions(+), 56 deletions(-)

This seems like a definite improvement at this point.  Applied, thanks.

jn