linux-kernel - Re: [PATCH v7 3/7] arm64: dts: agilex: Fix fixed-clock schema warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c5755f14-3efd-d4ef-4e34-6446608dedfd@linux.intel.com>
Date: Tue, 18 Feb 2025 13:44:36 -0800 (PST)
From: matthew.gerlach@...ux.intel.com
To: Krzysztof Kozlowski <krzk@...nel.org>
cc: lpieralisi@...nel.org, kw@...ux.com, manivannan.sadhasivam@...aro.org, 
    robh@...nel.org, bhelgaas@...gle.com, krzk+dt@...nel.org, 
    conor+dt@...nel.org, dinguyen@...nel.org, joyce.ooi@...el.com, 
    linux-pci@...r.kernel.org, devicetree@...r.kernel.org, 
    linux-kernel@...r.kernel.org, matthew.gerlach@...era.com, 
    peter.colberg@...era.com
Subject: Re: [PATCH v7 3/7] arm64: dts: agilex: Fix fixed-clock schema
 warnings



On Sun, 16 Feb 2025, Krzysztof Kozlowski wrote:

> On Sat, Feb 15, 2025 at 09:53:55AM -0600, Matthew Gerlach wrote:
>> All Agilex SoCs have the fixed-clocks defined in socfpga_agilex.dsti,
>
>
> That's not what I asked / talked about. If the clocks are in SoC, they
> cannot be disabled.

There are two clocks, cb_intoosc_hs_div2_clk and cb_intosc_ls_clk, in the 
SoC with a known frequency. These warnings can be fixed in the DTSI.

>
> If they clocks are not in SoC, they should not be in DTSI.

The two clocks, f2s_free_clk and osc1, are not in the SoC; so they should 
be removed from DTSI.

>
> These were my statements last time and this patch does not comple.
> Commit msg does not explain why this should be done differently.
>
> Best regards,
> Krzysztof
>
>

Thanks for the feedback,
Matthew Gerlach