linux-kernel - Re: [PATCH 1/2] clk: qcom: gdsc: Set retain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7834c2e5-8c0a-4223-abfb-e21ae82d9e0a@quicinc.com>
Date: Tue, 18 Feb 2025 12:33:45 +0530
From: Imran Shaik <quic_imrashai@...cinc.com>
To: Taniya Das <quic_tdas@...cinc.com>,
        Bjorn Andersson
	<andersson@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        "Stephen
 Boyd" <sboyd@...nel.org>
CC: Ajit Pandey <quic_ajipan@...cinc.com>,
        Jagadeesh Kona
	<quic_jkona@...cinc.com>,
        <linux-arm-msm@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <stable@...r.kernel.org>
Subject: Re: [PATCH 1/2] clk: qcom: gdsc: Set retain_ff before moving to HW
 CTRL



On 2/14/2025 9:56 AM, Taniya Das wrote:
> Enable the retain_ff_enable bit of GDSCR only if the GDSC is already ON.
> Once the GDSCR moves to HW control, SW no longer can determine the state
> of the GDSCR and setting the retain_ff bit could destroy all the register
> contents we intended to save.
> Therefore, move the retain_ff configuration before switching the GDSC to
> HW trigger mode.
> 
> Cc: stable@...r.kernel.org
> Fixes: 173722995cdb ("clk: qcom: gdsc: Add support to enable retention of GSDCR")
> Signed-off-by: Taniya Das <quic_tdas@...cinc.com>
> ---
>  drivers/clk/qcom/gdsc.c | 21 +++++++++++----------
>  1 file changed, 11 insertions(+), 10 deletions(-)
> 

Reviewed-by: Imran Shaik <quic_imrashai@...cinc.com>
Tested-by: Imran Shaik <quic_imrashai@...cinc.com> # on QCS8300