linux-kernel - Re: [PATCH v6] media: dt-bindings: aspeed,video-engine: Convert to json schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a8ff6545da9dceb2b745e6301e1f997ba97776fe.camel@codeconstruct.com.au>
Date: Tue, 18 Feb 2025 11:37:46 +1030
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: Jammy Huang <jammy_huang@...eedtech.com>, "eajames@...ux.ibm.com"
 <eajames@...ux.ibm.com>, "mchehab@...nel.org" <mchehab@...nel.org>, 
 "robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
 <krzk+dt@...nel.org>,  "conor+dt@...nel.org" <conor+dt@...nel.org>,
 "joel@....id.au" <joel@....id.au>, "andrew@...id.au" <andrew@...id.au>,
 "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>, 
 "openbmc@...ts.ozlabs.org" <openbmc@...ts.ozlabs.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
 <linux-aspeed@...ts.ozlabs.org>, "linux-kernel@...r.kernel.org"
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6] media: dt-bindings: aspeed,video-engine: Convert to
 json schema

On Mon, 2025-02-17 at 02:11 +0000, Jammy Huang wrote:
> Hi Andrew,
> 
> Thanks for your feedback, please find my explanation below.
> 
> > 
> > On Thu, 2025-02-13 at 09:53 +0800, Jammy Huang wrote:
> > > Convert aspeed-video.txt to yaml format.
> > > Update aspeed-video.txt to aspeed,video-engine.yaml in MAINTAINER file.
> > > 
> > > Signed-off-by: Jammy Huang <jammy_huang@...eedtech.com>
> > > 
...
> > > +
> > > +required:
> > > +  - compatible
> > > +  - reg
> > > +  - clocks
> > > +  - clock-names
> > > +  - interrupts
> > 
> > This should list `resets` as well, as that wasn't optional in the text binding.
> > 
> 'resets' is not listed as required here is because ASPEED handle reset in the clock driver
> in ast2600/ast2500/..., etc. So I keep this part identical as previous aspeed-video.txt.

It's not identical though. The text binding listed the _optional_
properties, while the yaml binding lists the _required_ properties. The
reset property appears in neither list across two binding definitions,
but it has to be in one or the other for consistency.

However, it sounds like the text binding was not accurate, and this is
reflected in the video nodes in the SoC DTSIs. The yaml binding
definition at least matches that reality.

Andrew