linux-kernel - Re: [PATCH v2 3/5] dt-bindings: net: bcm6368-mdio-mux: add gphy-ctrl property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250218-glaring-maroon-impala-1eb78a@krzk-bin>
Date: Tue, 18 Feb 2025 08:32:41 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Kyle Hendry <kylehendrydev@...il.com>
Cc: Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Heiner Kallweit <hkallweit1@...il.com>, 
	Russell King <linux@...linux.org.uk>, Florian Fainelli <florian.fainelli@...adcom.com>, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, Fernández Rojas <noltari@...il.com>, 
	Jonas Gorski <jonas.gorski@...il.com>, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	netdev@...r.kernel.org
Subject: Re: [PATCH v2 3/5] dt-bindings: net: bcm6368-mdio-mux: add gphy-ctrl
 property

On Mon, Feb 17, 2025 at 05:36:42PM -0800, Kyle Hendry wrote:
> Add documentation for the brcm,gphy-ctrl phandle to the
> register for controlling ghpy modes.
> 
> Signed-off-by: Kyle Hendry <kylehendrydev@...il.com>
> ---
>  .../devicetree/bindings/net/brcm,bcm6368-mdio-mux.yaml     | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/brcm,bcm6368-mdio-mux.yaml b/Documentation/devicetree/bindings/net/brcm,bcm6368-mdio-mux.yaml
> index 9ef28c2a0afc..9630b87b0473 100644
> --- a/Documentation/devicetree/bindings/net/brcm,bcm6368-mdio-mux.yaml
> +++ b/Documentation/devicetree/bindings/net/brcm,bcm6368-mdio-mux.yaml
> @@ -24,6 +24,11 @@ properties:
>    reg:
>      maxItems: 1
>  

Looks like whitespace error

> +properties:
> +  brcm,gphy-ctrl:
> +    $ref: /schemas/types.yaml#/definitions/phandle-array
> +    description: A phandle to the gphy control register

Missing items. Why is this array?

Anyway, explain the purpose of this phandle - how it is used by the
*device*.

Best regards,
Krzysztof