linux-kernel - Re: [PATCH v2 5/5] dt-bindings: mfd: brcm: add gphy controller to BCM63268 sysctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250218-fearless-statuesque-zebra-3e79a8@krzk-bin>
Date: Tue, 18 Feb 2025 08:35:18 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Kyle Hendry <kylehendrydev@...il.com>
Cc: Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Heiner Kallweit <hkallweit1@...il.com>, 
	Russell King <linux@...linux.org.uk>, Florian Fainelli <florian.fainelli@...adcom.com>, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, Fernández Rojas <noltari@...il.com>, 
	Jonas Gorski <jonas.gorski@...il.com>, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	netdev@...r.kernel.org
Subject: Re: [PATCH v2 5/5] dt-bindings: mfd: brcm: add gphy controller to
 BCM63268 sysctl

On Mon, Feb 17, 2025 at 05:36:44PM -0800, Kyle Hendry wrote:
> Add documentation for BCM63268 gphy controller in the
> bcm63268-gpio-sysctl register range.
> 
> Signed-off-by: Kyle Hendry <kylehendrydev@...il.com>
> ---
>  .../bindings/mfd/brcm,bcm63268-gpio-sysctl.yaml     | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/brcm,bcm63268-gpio-sysctl.yaml b/Documentation/devicetree/bindings/mfd/brcm,bcm63268-gpio-sysctl.yaml
> index 9c2a04829da5..99610a5f2912 100644
> --- a/Documentation/devicetree/bindings/mfd/brcm,bcm63268-gpio-sysctl.yaml
> +++ b/Documentation/devicetree/bindings/mfd/brcm,bcm63268-gpio-sysctl.yaml
> @@ -50,6 +50,15 @@ patternProperties:
>        should follow the bindings specified in
>        Documentation/devicetree/bindings/pinctrl/brcm,bcm63268-pinctrl.yaml.
>  
> +  "^gphy_ctrl@[0-9a-f]+$":

Read DTS coding style.

> +    # Child node
> +    type: object
> +    $ref: /schemas/mfd/syscon.yaml

No, not really... how is syscon a child of other syscon? Isn't the other
device the syscon?

This looks really fake hardware description, like recent bootlin claim that
"one register in syscon is device".

> +    description:
> +      Control register for GPHY modes. This child node definition
> +      should follow the bindings specified in
> +      Documentation/devicetree/bindings/mfd/syscon.yaml
> +
>  required:
>    - "#address-cells"
>    - compatible
> @@ -191,4 +200,8 @@ examples:
>            pins = "dsl_gpio9";
>          };
>        };
> +      gphy_ctrl: gphy_ctrl@54 {
> +      compatible = "brcm,bcm63268-gphy-ctrl", "syscon";

Messed indentation.

Best regards,
Krzysztof