linux-kernel - Re: [PATCH] kunit: Clarify kunit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABVgOSk3PxgPi-ZWiXeZy751Pra8O1OspsJGk_fotxVcmJ8SHw@mail.gmail.com>
Date: Tue, 18 Feb 2025 15:41:16 +0800
From: David Gow <davidgow@...gle.com>
To: Kevin Brodsky <kevin.brodsky@....com>
Cc: kunit-dev@...glegroups.com, linux-kernel@...r.kernel.org, 
	Brendan Higgins <brendan.higgins@...ux.dev>, Rae Moar <rmoar@...gle.com>, 
	linux-kselftest@...r.kernel.org
Subject: Re: [PATCH] kunit: Clarify kunit_skip() argument name

On Mon, 17 Feb 2025 at 22:00, Kevin Brodsky <kevin.brodsky@....com> wrote:
>
> kunit_skip() and kunit_mark_skipped() can only be passed a pointer
> to a struct kunit, not struct kunit_suite (only kunit_log() actually
> supports both). Rename their first argument accordingly.
>
> Signed-off-by: Kevin Brodsky <kevin.brodsky@....com>
> ---
> Cc: Brendan Higgins <brendan.higgins@...ux.dev>
> Cc: David Gow <davidgow@...gle.com>
> Cc: Rae Moar <rmoar@...gle.com>
> Cc: linux-kselftest@...r.kernel.org
> ---

Thanks. We probably should support skipping (the rest of) a suite, but
let's not pretend we do when we don't!

Reviewed-by: David Gow <davidgow@...gle.com>

Cheers,
-- David

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5294 bytes)