linux-kernel - Re: [PATCH v5 2/3] staging:gpib:agilent_82350b.c: cleaned commented out code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025021856-unrented-property-c111@gregkh>
Date: Tue, 18 Feb 2025 08:51:59 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Ravi Kumar kairi <kumarkairiravi@...il.com>
Cc: dpenkler@...il.com, kuba@...nel.org, dan.carpenter@...aro.org,
	rmk+kernel@...linux.org.uk, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 2/3] staging:gpib:agilent_82350b.c: cleaned commented
 out code

On Tue, Feb 18, 2025 at 01:20:49AM +0530, Ravi Kumar kairi wrote:
> From: Ravi Kumar Kairi <kumarkairiravi@...il.com>
> 
> cleaned code that was commented out and cleaned blank line that resulted
> from cleaning out commented code
> 
> Signed-off-by: Ravi Kumar Kairi <kumarkairiravi@...il.com>
> ---
>  .../staging/gpib/agilent_82350b/agilent_82350b.c   | 14 --------------
>  1 file changed, 14 deletions(-)
> 
> diff --git a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c
> index 5a74a22015..af1bf6e893 100644
> --- a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c
> +++ b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c
> @@ -176,8 +176,6 @@ static int agilent_82350b_accel_write(gpib_board_t *board, uint8_t *buffer, size
>  
>  	event_status = read_and_clear_event_status(board);
>  
> -	//pr_info("ag_ac_wr: event status 0x%x tms state 0x%lx\n", event_status, tms_priv->state);
> -
>  #ifdef EXPERIMENTAL
>  	pr_info("ag_ac_wr: wait for previous BO to complete if any\n");
>  	retval = wait_event_interruptible(board->wait,
> @@ -190,14 +188,11 @@ static int agilent_82350b_accel_write(gpib_board_t *board, uint8_t *buffer, size
>  		return retval;
>  #endif
>  
> -	//pr_info("ag_ac_wr: sending first byte\n");
>  	retval = agilent_82350b_write(board, buffer, 1, 0, &num_bytes);
>  	*bytes_written += num_bytes;
>  	if (retval < 0)
>  		return retval;
>  
> -	//pr_info("ag_ac_wr: %ld bytes eoi %d tms state 0x%lx\n",length, send_eoi, tms_priv->state);
> -
>  	write_byte(tms_priv, tms_priv->imr0_bits & ~HR_BOIE, IMR0);
>  	for (i = 1; i < fifotransferlength;) {
>  		clear_bit(WRITE_READY_BN, &tms_priv->state);
> @@ -210,12 +205,8 @@ static int agilent_82350b_accel_write(gpib_board_t *board, uint8_t *buffer, size
>  		}
>  		writeb(ENABLE_TI_TO_SRAM, a_priv->gpib_base + SRAM_ACCESS_CONTROL_REG);
>  
> -		//pr_info("ag_ac_wr: send block: %d bytes tms 0x%lx\n", block_size,
> -		// tms_priv->state);
> -
>  		if (agilent_82350b_fifo_is_halted(a_priv)) {
>  			writeb(RESTART_STREAM_BIT, a_priv->gpib_base + STREAM_STATUS_REG);
> -			//	pr_info("ag_ac_wr: needed restart\n");
>  		}
>  
>  		retval = wait_event_interruptible(board->wait,
> @@ -226,7 +217,6 @@ static int agilent_82350b_accel_write(gpib_board_t *board, uint8_t *buffer, size
>  						  test_bit(TIMO_NUM, &board->status));
>  		writeb(0, a_priv->gpib_base + SRAM_ACCESS_CONTROL_REG);
>  		num_bytes = block_size - read_transfer_counter(a_priv);
> -		//pr_info("ag_ac_wr: sent  %ld bytes tms 0x%lx\n", num_bytes, tms_priv->state);
>  
>  		*bytes_written += num_bytes;
>  		retval = translate_wait_return_value(board, retval);
> @@ -238,9 +228,6 @@ static int agilent_82350b_accel_write(gpib_board_t *board, uint8_t *buffer, size
>  		return retval;
>  
>  	if (send_eoi) {
> -		//pr_info("ag_ac_wr: sending last byte with eoi byte no:   %d\n",
> -		// fifotransferlength+1);
> -
>  		retval = agilent_82350b_write(board, buffer + fifotransferlength, 1, send_eoi,
>  					      &num_bytes);
>  		*bytes_written += num_bytes;
> @@ -284,7 +271,6 @@ static irqreturn_t agilent_82350b_interrupt(int irq, void *arg)
>  		tms9914_interrupt_have_status(board, &a_priv->tms9914_priv, tms9914_status1,
>  					      tms9914_status2);
>  	}
> -//pr_info("event_status=0x%x s1 %x s2 %x\n", event_status,tms9914_status1,tms9914_status2);
>  //write-clear status bits
>  	if (event_status & (BUFFER_END_STATUS_BIT | TERM_COUNT_STATUS_BIT)) {
>  		writeb(event_status & (BUFFER_END_STATUS_BIT | TERM_COUNT_STATUS_BIT),
> -- 
> 2.48.1
> 
>


Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot