linux-kernel - [PATCH v2 08/14] x86: Physical address comparisons in fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c5191b5bee5e0418752bf1c6159a2f0ce3490c1d.1739866028.git.maciej.wieczor-retman@intel.com>
Date: Tue, 18 Feb 2025 09:15:24 +0100
From: Maciej Wieczor-Retman <maciej.wieczor-retman@...el.com>
To: kees@...nel.org,
	julian.stecklina@...erus-technology.de,
	kevinloughlin@...gle.com,
	peterz@...radead.org,
	tglx@...utronix.de,
	justinstitt@...gle.com,
	catalin.marinas@....com,
	wangkefeng.wang@...wei.com,
	bhe@...hat.com,
	ryabinin.a.a@...il.com,
	kirill.shutemov@...ux.intel.com,
	will@...nel.org,
	ardb@...nel.org,
	jason.andryuk@....com,
	dave.hansen@...ux.intel.com,
	pasha.tatashin@...een.com,
	ndesaulniers@...gle.com,
	guoweikang.kernel@...il.com,
	dwmw@...zon.co.uk,
	mark.rutland@....com,
	broonie@...nel.org,
	apopple@...dia.com,
	bp@...en8.de,
	rppt@...nel.org,
	kaleshsingh@...gle.com,
	richard.weiyang@...il.com,
	luto@...nel.org,
	glider@...gle.com,
	pankaj.gupta@....com,
	andreyknvl@...il.com,
	pawan.kumar.gupta@...ux.intel.com,
	kuan-ying.lee@...onical.com,
	tony.luck@...el.com,
	tj@...nel.org,
	jgross@...e.com,
	dvyukov@...gle.com,
	baohua@...nel.org,
	samuel.holland@...ive.com,
	dennis@...nel.org,
	akpm@...ux-foundation.org,
	thomas.weissschuh@...utronix.de,
	surenb@...gle.com,
	kbingham@...nel.org,
	ankita@...dia.com,
	nathan@...nel.org,
	maciej.wieczor-retman@...el.com,
	ziy@...dia.com,
	xin@...or.com,
	rafael.j.wysocki@...el.com,
	andriy.shevchenko@...ux.intel.com,
	cl@...ux.com,
	jhubbard@...dia.com,
	hpa@...or.com,
	scott@...amperecomputing.com,
	david@...hat.com,
	jan.kiszka@...mens.com,
	vincenzo.frascino@....com,
	corbet@....net,
	maz@...nel.org,
	mingo@...hat.com,
	arnd@...db.de,
	ytcoode@...il.com,
	xur@...gle.com,
	morbo@...gle.com,
	thiago.bauermann@...aro.org
Cc: linux-doc@...r.kernel.org,
	kasan-dev@...glegroups.com,
	linux-kernel@...r.kernel.org,
	llvm@...ts.linux.dev,
	linux-mm@...ck.org,
	linux-arm-kernel@...ts.infradead.org,
	x86@...nel.org
Subject: [PATCH v2 08/14] x86: Physical address comparisons in fill_p*d/pte

Calculating page offset returns a pointer without a tag. When comparing
the calculated offset to a tagged page pointer an error is raised
because they are not equal.

Change pointer comparisons to physical address comparisons as to avoid
issues with tagged pointers that pointer arithmetic would create. Open
code pte_offset_kernel(), pmd_offset(), pud_offset() and p4d_offset().
Because one parameter is always zero and the rest of the function
insides are enclosed inside __va(), removing that layer lowers the
complexity of final assembly.

Signed-off-by: Maciej Wieczor-Retman <maciej.wieczor-retman@...el.com>
---
Changelog v2:
- Open code *_offset() to avoid it's internal __va().

 arch/x86/mm/init_64.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
index 01ea7c6df303..e555895dbb68 100644
--- a/arch/x86/mm/init_64.c
+++ b/arch/x86/mm/init_64.c
@@ -251,7 +251,10 @@ static p4d_t *fill_p4d(pgd_t *pgd, unsigned long vaddr)
 	if (pgd_none(*pgd)) {
 		p4d_t *p4d = (p4d_t *)spp_getpage();
 		pgd_populate(&init_mm, pgd, p4d);
-		if (p4d != p4d_offset(pgd, 0))
+
+		if (__pa(p4d) != (pgtable_l5_enabled() ?
+				  __pa(pgd) :
+				  (unsigned long)pgd_val(*pgd) & PTE_PFN_MASK))
 			printk(KERN_ERR "PAGETABLE BUG #00! %p <-> %p\n",
 			       p4d, p4d_offset(pgd, 0));
 	}
@@ -263,7 +266,7 @@ static pud_t *fill_pud(p4d_t *p4d, unsigned long vaddr)
 	if (p4d_none(*p4d)) {
 		pud_t *pud = (pud_t *)spp_getpage();
 		p4d_populate(&init_mm, p4d, pud);
-		if (pud != pud_offset(p4d, 0))
+		if (__pa(pud) != (p4d_val(*p4d) & p4d_pfn_mask(*p4d)))
 			printk(KERN_ERR "PAGETABLE BUG #01! %p <-> %p\n",
 			       pud, pud_offset(p4d, 0));
 	}
@@ -275,7 +278,7 @@ static pmd_t *fill_pmd(pud_t *pud, unsigned long vaddr)
 	if (pud_none(*pud)) {
 		pmd_t *pmd = (pmd_t *) spp_getpage();
 		pud_populate(&init_mm, pud, pmd);
-		if (pmd != pmd_offset(pud, 0))
+		if (__pa(pmd) != (pud_val(*pud) & pud_pfn_mask(*pud)))
 			printk(KERN_ERR "PAGETABLE BUG #02! %p <-> %p\n",
 			       pmd, pmd_offset(pud, 0));
 	}
@@ -287,7 +290,7 @@ static pte_t *fill_pte(pmd_t *pmd, unsigned long vaddr)
 	if (pmd_none(*pmd)) {
 		pte_t *pte = (pte_t *) spp_getpage();
 		pmd_populate_kernel(&init_mm, pmd, pte);
-		if (pte != pte_offset_kernel(pmd, 0))
+		if (__pa(pte) != (pmd_val(*pmd) & pmd_pfn_mask(*pmd)))
 			printk(KERN_ERR "PAGETABLE BUG #03!\n");
 	}
 	return pte_offset_kernel(pmd, vaddr);
-- 
2.47.1