linux-kernel - Re: [PATCH v3] pinctrl: spacemit: enable config option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <874j0rr65p.fsf@minerva.mail-host-address-is-not-set>
Date: Tue, 18 Feb 2025 09:47:14 +0100
From: Javier Martinez Canillas <javierm@...hat.com>
To: Yixun Lan <dlan@...too.org>, Linus Walleij <linus.walleij@...aro.org>,
 Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt
 <palmer@...belt.com>
Cc: Alex Elder <elder@...nel.org>, linux-riscv@...ts.infradead.org,
 linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
 spacemit@...ts.linux.dev, Conor Dooley <conor.dooley@...rochip.com>, Alex
 Elder <elder@...cstar.com>, Yixun Lan <dlan@...too.org>
Subject: Re: [PATCH v3] pinctrl: spacemit: enable config option

Yixun Lan <dlan@...too.org> writes:

> Pinctrl is an essential driver for SpacemiT's SoC,
> The uart driver requires it, same as sd card driver,
> so let's enable it by default for this SoC.
>
> The CONFIG_PINCTRL_SPACEMIT_K1 isn't enabled when using
> 'make defconfig' to select kernel configuration options.
> This result in a broken uart driver where fail at probe()
> stage due to no pins found.
>
> Fixes: a83c29e1d145 ("pinctrl: spacemit: add support for SpacemiT K1 SoC")
> Reported-by: Alex Elder <elder@...nel.org>
> Acked-by: Conor Dooley <conor.dooley@...rochip.com>
> Tested-by: Alex Elder <elder@...cstar.com>
> Signed-off-by: Yixun Lan <dlan@...too.org>
> ---
> This should fix problem that CONFIG_PINCTRL_SPACEMIT_K1 is not enabled
> when using make defconfig, thus fail to initilize uart driver which requst
> pins during probe stage.
> ---

Reviewed-by: Javier Martinez Canillas <javierm@...hat.com>
Tested-by: Javier Martinez Canillas <javierm@...hat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat