linux-kernel - Re: [PATCH v2] media: verisilicon: Fix AV1 decoder clock frequency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <15bbca6567ff640fdcfbe1a9525989887a94732c.camel@pengutronix.de>
Date: Tue, 18 Feb 2025 10:03:35 +0100
From: Philipp Zabel <p.zabel@...gutronix.de>
To: Nicolas Dufresne <nicolas.dufresne@...labora.com>, Benjamin Gaignard
 <benjamin.gaignard@...labora.com>, Mauro Carvalho Chehab
 <mchehab@...nel.org>,  Heiko Stuebner <heiko@...ech.de>, Hans Verkuil
 <hverkuil@...all.nl>
Cc: linux-rockchip@...ts.infradead.org,
 linux-arm-kernel@...ts.infradead.org,  linux-kernel@...r.kernel.org,
 linux-media@...r.kernel.org, kernel@...labora.com,  stable@...r.kernel.org
Subject: Re: [PATCH v2] media: verisilicon: Fix AV1 decoder clock frequency

On Mo, 2025-02-17 at 16:46 -0500, Nicolas Dufresne wrote:
> The desired clock frequency was correctly set to 400MHz in the device tree
> but was lowered by the driver to 300MHz breaking 4K 60Hz content playback.
> Fix the issue by removing the driver call to clk_set_rate(), which reduce
> the amount of board specific code.
> 
> Fixes: 003afda97c65 ("media: verisilicon: Enable AV1 decoder on rk3588")
> Cc: stable@...r.kernel.org
> Signed-off-by: Nicolas Dufresne <nicolas.dufresne@...labora.com>

I was going to ask whether there might be any device trees without the
assigned-clock-rates around that this patch could break, but the DT
node was introduced with 400 MHz clock setting in the initial commit
dd6dc0c4c126 ("arm64: dts: rockchip: Add AV1 decoder node to rk3588s").

Reviewed-by: Philipp Zabel <p.zabel@...gutronix.de>

regards
Philipp