linux-kernel - Re: [RESEND PATCH v6 0/8] perf: Support searching local debugging vdso or specify vdso path in cmdline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <lytsbawzokllz3nh36at3bi6322sk5br3vrqp5lr75eiwdqqj3@ozmbwylc5gdg>
Date: Tue, 18 Feb 2025 17:56:17 +0800
From: YinFengwei <fengwei_yin@...ux.alibaba.com>
To: Changbin Du <changbin.du@...wei.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, 
	Arnaldo Carvalho de Melo <acme@...nel.org>, Namhyung Kim <namhyung@...nel.org>, 
	Nathan Chancellor <nathan@...nel.org>, Mark Rutland <mark.rutland@....com>, 
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>, 
	Adrian Hunter <adrian.hunter@...el.com>, "Liang, Kan" <kan.liang@...ux.intel.com>, 
	Nick Desaulniers <ndesaulniers@...gle.com>, Bill Wendling <morbo@...gle.com>, 
	Justin Stitt <justinstitt@...gle.com>, linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org, 
	llvm@...ts.linux.dev, Hui Wang <hw.huiwang@...wei.com>
Subject: Re: [RESEND PATCH v6 0/8] perf: Support searching local debugging
 vdso or specify vdso path in cmdline

Hi Changbin,

On Fri, Aug 16, 2024 at 06:58:03PM +0800, Changbin Du wrote:
> The vdso dumped from process memory (in buildid-cache) lacks debugging
> info. To annotate vdso symbols with source lines we need a debugging
> version.
> 
> For x86, we can find them from your local build as
> 'arch/x86/entry/vdso/vdso{32,64}.so.dbg'. Or they may resides in
> '/lib/modules/<version>/vdso/vdso{32,64}.so' on Ubuntu. But notice that the
> builid has to match.
> 
> If user doesn't specify the path, perf will search them internally as long
> as vmlinux when recording samples. The searched debugging vdso will add to
> buildid cache as ~/.debug/[vdso]/debug.
> 
> Below samples are captured on my local build kernel. perf succesfully
> find debugging version vdso and we can annotate with source without
> specifying vdso path.
> 
> $ sudo perf record -a
> $ sudo perf report --objdump=llvm-objdump
> 
> Samples: 17K of event 'cycles:P', 4000 Hz, Event count (approx.): 1760
> __vdso_clock_gettime  /work/linux-host/arch/x86/entry/vdso/vdso64.so.d
> Percent│       movq    -48(%rbp),%rsi
>        │       testq   %rax,%rax
>        │     ;               return vread_hvclock();
>        │       movq    %rax,%rdx
>        │     ;               if (unlikely(!vdso_cycles_ok(cycles)))
>        │     ↑ js      eb
>        │     ↑ jmp     74
>        │     ;               ts->tv_sec = vdso_ts->sec;
>   0.02 │147:   leaq    2(%rbx),%rax
>        │       shlq    $4, %rax
>        │       addq    %r10,%rax
>        │     ;               while ((seq = READ_ONCE(vd->seq)) & 1) {
>   9.38 │152:   movl    (%r10),%ecx
> 
> When doing cross platform analysis, we need to specify the vdso path manually if
> we are interested in its symbols, because they are not installed on local
> machine. At most two vdso can be given. Also you can pack your buildid cache with
> perf-archive if the debugging vdso can be found on the sampled machine.
> 
> $ sudo perf report --objdump=llvm-objdump \
>       --vdso arch/x86/entry/vdso/vdso64.so.dbg,arch/x86/entry/vdso/vdso32.so.dbg
With latest upstream kernel, I still can't annotate symbols in vdso.
With your patch and this --vdso command, it works great on x86 and arm64
platform. So
   Tested-by: Yin Fengwei <fengwei_yin@...ux.alibaba.com>


Regards
Yin, Fengwei

> 
> I also improved perf-buildid-cache command to recognize vdso when adding files,
> then place it at correct place.
> 
> $ sudo perf buildid-cache --add /work/linux/arch/x86/entry/vdso/vdso64.so.dbg