linux-kernel - Re: [PATCH REPOST] selftests: net: Fix minor typos in MPTCP and psock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f5e6302e-f91a-4fc8-b12e-faebb7c26e05@kernel.org>
Date: Tue, 18 Feb 2025 11:18:37 +0100
From: Matthieu Baerts <matttbe@...nel.org>
To: Suchit K <suchitkarunakaran@...il.com>, netdev@...r.kernel.org
Cc: kuba@...nel.org, horms@...nel.org, skhan@...uxfoundation.org,
 linux-kernel-mentees@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH REPOST] selftests: net: Fix minor typos in MPTCP and
 psock_tpacket tests

Hi Suchit,

On 18/02/2025 10:28, Suchit K wrote:
> Fixes minor spelling errors:
> - `simult_flows.sh`: "al testcases" -> "all testcases"
> - `psock_tpacket.c`: "accross" -> "across"
> 
> Signed-off-by: Suchit Karunakaran <suchitkarunakaran@...il.com>
> ---
>  tools/testing/selftests/net/mptcp/simult_flows.sh | 2 +-
>  tools/testing/selftests/net/psock_tpacket.c       | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/net/mptcp/simult_flows.sh
> b/tools/testing/selftests/net/mptcp/simult_flows.sh

The patch is exactly the same as v1, containing the same issues: long
lines are wrapped, corrupting the patch, like here above.

> index 9c2a41597..2329c2f85 100755
> --- a/tools/testing/selftests/net/mptcp/simult_flows.sh
> +++ b/tools/testing/selftests/net/mptcp/simult_flows.sh
> @@ -28,7 +28,7 @@ size=0
> 
>  usage() {
>   echo "Usage: $0 [ -b ] [ -c ] [ -d ] [ -i]"
> - echo -e "\t-b: bail out after first error, otherwise runs al testcases"
> + echo -e "\t-b: bail out after first error, otherwise runs all testcases"
>   echo -e "\t-c: capture packets for each test using tcpdump (default:
> no capture)"

Same here

>   echo -e "\t-d: debug this script"
>   echo -e "\t-i: use 'ip mptcp' instead of 'pm_nl_ctl'"
> diff --git a/tools/testing/selftests/net/psock_tpacket.c
> b/tools/testing/selftests/net/psock_tpacket.c

Same here

> index 404a2ce75..221270cee 100644
> --- a/tools/testing/selftests/net/psock_tpacket.c
> +++ b/tools/testing/selftests/net/psock_tpacket.c
> @@ -12,7 +12,7 @@
>   *
>   * Datapath:
>   *   Open a pair of packet sockets and send resp. receive an a priori known
> - *   packet pattern accross the sockets and check if it was received resp.
> + *   packet pattern across the sockets and check if it was received resp.
>   *   sent correctly. Fanout in combination with RX_RING is currently not
>   *   tested here.
>   *

How are you sending this patch? Using 'git send-email' following
instructions like the ones from [1]?

I do recommend using b4 to prepare and send patches, see [2].

[1] https://git-send-email.io
[2] https://b4.docs.kernel.org/en/latest/contributor/overview.html

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.