linux-kernel - Re: [PATCH] block: set bi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f4f4fff4-5055-47f7-9f24-6b1780920f4d@oracle.com>
Date: Tue, 18 Feb 2025 10:40:35 +0000
From: John Garry <john.g.garry@...cle.com>
To: Andreas Hindborg <a.hindborg@...nel.org>, Jens Axboe <axboe@...nel.dk>
Cc: Oliver Mangold <oliver.mangold@...me>, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block: set bi_vcnt when cloning bio

On 15/02/2025 10:58, Andreas Hindborg wrote:
> When cloning a bio, the `bio.bi_vcnt` field is not cloned. This is a
> problem if users want to perform bounds checks on the `bio.bi_io_vec`
> field.

Is this fixing a potential problem? Or fixing a real issue?

Thanks,
John

> 
> Signed-off-by: Andreas Hindborg <a.hindborg@...nel.org>
> ---
>   block/bio.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/block/bio.c b/block/bio.c
> index f0c416e5931d9..334eedf312803 100644
> --- a/block/bio.c
> +++ b/block/bio.c
> @@ -870,6 +870,7 @@ struct bio *bio_alloc_clone(struct block_device *bdev, struct bio *bio_src,
>   		return NULL;
>   	}
>   	bio->bi_io_vec = bio_src->bi_io_vec;
> +	bio->bi_vcnt = bio_src->bi_vcnt;
>   
>   	return bio;
>   }
> 
> ---
> base-commit: a64dcfb451e254085a7daee5fe51bf22959d52d3
> change-id: 20250215-clone-bi_vcnt-f3f770988894
> 
> Best regards,