linux-kernel - drivers/leds/leds-st1202.c:194:66-71: WARNING: conversion to bool not needed here

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202502181845.xESVrC61-lkp@intel.com>
Date: Tue, 18 Feb 2025 18:54:23 +0800
From: kernel test robot <lkp@...el.com>
To: Vicentiu Galanopulo <vicentiu.galanopulo@...ote-tech.co.uk>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Lee Jones <lee@...nel.org>
Subject: drivers/leds/leds-st1202.c:194:66-71: WARNING: conversion to bool
 not needed here

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   2408a807bfc3f738850ef5ad5e3fd59d66168996
commit: 939757aafeb9c266dda37657ee5f7a73ffd35ae2 leds: Add LED1202 I2C driver
date:   6 weeks ago
config: x86_64-randconfig-103-20250218 (https://download.01.org/0day-ci/archive/20250218/202502181845.xESVrC61-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502181845.xESVrC61-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/leds/leds-st1202.c:194:66-71: WARNING: conversion to bool not needed here

vim +194 drivers/leds/leds-st1202.c

   188	
   189	static int st1202_led_set(struct led_classdev *ldev, enum led_brightness value)
   190	{
   191		struct st1202_led *led = cdev_to_st1202_led(ldev);
   192		struct st1202_chip *chip = led->chip;
   193	
 > 194		return st1202_channel_set(chip, led->led_num, value == LED_OFF ? false : true);
   195	}
   196	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki